BASH PATCH REPORT

			     =================

Bash-Release:	4.0

Patch-ID:	bash40-039

Bug-Reported-by:	Stephane Chazelas <[email protected]>

Bug-Reference-ID:

Bug-Reference-URL:

Bug-Description:

Under certain circumstances, bash will execute user code while processing the

environment for exported function definitions.

Patch (apply with `patch -p0'):

*** ../bash-4.0.38/builtins/common.h	2009-01-15 23:08:54.000000000 -0500

--- builtins/common.h	2014-09-16 19:20:48.000000000 -0400

***************

*** 36,39 ****

--- 36,41 ----

  /* Flags for describe_command, shared between type.def and command.def */

+ #define SEVAL_FUNCDEF	0x080		/* only allow function definitions */

+ #define SEVAL_ONECMD	0x100		/* only allow a single command */

  #define CDESC_ALL		0x001	/* type -a */

  #define CDESC_SHORTDESC		0x002	/* command -V */

*** ../bash-4.0.38/builtins/evalstring.c	2009-01-13 14:44:12.000000000 -0500

--- builtins/evalstring.c	2014-09-16 19:20:48.000000000 -0400

***************

*** 259,262 ****

--- 259,270 ----

  	      struct fd_bitmap *bitmap;

+ 	      if ((flags & SEVAL_FUNCDEF) && command->type != cm_function_def)

+ 		{

+ 		  internal_warning ("%s: ignoring function definition attempt", from_file);

+ 		  should_jump_to_top_level = 0;

+ 		  last_result = last_command_exit_value = EX_BADUSAGE;

+ 		  break;

+ 		}

+ 

  	      bitmap = new_fd_bitmap (FD_BITMAP_SIZE);

  	      begin_unwind_frame ("pe_dispose");

***************

*** 319,322 ****

--- 327,333 ----

  	      dispose_fd_bitmap (bitmap);

  	      discard_unwind_frame ("pe_dispose");

+ 

+ 	      if (flags & SEVAL_ONECMD)

+ 		break;

  	    }

  	}

*** ../bash-4.0.38/variables.c	2009-09-19 13:04:23.000000000 -0400

--- variables.c	2014-09-16 19:20:48.000000000 -0400

***************

*** 344,353 ****

  	  strcpy (temp_string + char_index + 1, string);

! 	  parse_and_execute (temp_string, name, SEVAL_NONINT|SEVAL_NOHIST);

! 

! 	  /* Ancient backwards compatibility.  Old versions of bash exported

! 	     functions like name()=() {...} */

! 	  if (name[char_index - 1] == ')' && name[char_index - 2] == '(')

! 	    name[char_index - 2] = '\0';

  	  if (temp_var = find_function (name))

--- 344,351 ----

  	  strcpy (temp_string + char_index + 1, string);

! 	  /* Don't import function names that are invalid identifiers from the

! 	     environment. */

! 	  if (legal_identifier (name))

! 	    parse_and_execute (temp_string, name, SEVAL_NONINT|SEVAL_NOHIST|SEVAL_FUNCDEF|SEVAL_ONECMD);

  	  if (temp_var = find_function (name))

***************

*** 358,365 ****

  	  else

  	    report_error (_("error importing function definition for `%s'"), name);

- 

- 	  /* ( */

- 	  if (name[char_index - 1] == ')' && name[char_index - 2] == '\0')

- 	    name[char_index - 2] = '(';		/* ) */

  	}

  #if defined (ARRAY_VARS)

--- 356,359 ----

*** ../bash-4.0/patchlevel.h	2009-01-04 14:32:40.000000000 -0500

--- patchlevel.h	2009-02-22 16:11:31.000000000 -0500

***************

*** 26,30 ****

     looks for to find the patch level (for the sccs version string). */

! #define PATCHLEVEL 38

  #endif /* _PATCHLEVEL_H_ */

--- 26,30 ----

     looks for to find the patch level (for the sccs version string). */

! #define PATCHLEVEL 39

  #endif /* _PATCHLEVEL_H_ */