20530019 Upgrade Wireshark to version 1.12.3
authorPetr Sumbera <petr.sumbera@oracle.com>
Thu, 12 Feb 2015 06:05:38 -0800
changeset 3878 b6ed43d2d1b8
parent 3875 5755dd506600
child 3879 f0286c1c2714
20530019 Upgrade Wireshark to version 1.12.3 19016321 Support for DCBx-CEE TLVs in wireshark
components/wireshark/Makefile
components/wireshark/patches/DesktopEntry.patch
components/wireshark/patches/evb.patch
components/wireshark/patches/man.patch
components/wireshark/wireshark-common.p5m
--- a/components/wireshark/Makefile	Sun Mar 01 10:25:15 2015 -0800
+++ b/components/wireshark/Makefile	Thu Feb 12 06:05:38 2015 -0800
@@ -23,16 +23,16 @@
 include ../../make-rules/shared-macros.mk
 
 COMPONENT_NAME=		wireshark
-COMPONENT_VERSION=	1.10.12
+COMPONENT_VERSION=	1.12.3
 COMPONENT_PROJECT_URL=	http://www.wireshark.org/
 COMPONENT_SRC=		$(COMPONENT_NAME)-$(COMPONENT_VERSION)
 COMPONENT_ARCHIVE=	$(COMPONENT_SRC).tar.bz2
 COMPONENT_ARCHIVE_HASH=	\
-    sha256:e8fe3993b60a93106fad3b186ab8adb7a88ef06549a4b2bc2755db84725720ae
+    sha256:69950b9dcb1a630982b5f680554d73d27ee0dc856fc6aeef88c8d04eb5ac33ea
 COMPONENT_ARCHIVE_URL=	$(COMPONENT_PROJECT_URL)download/src/all-versions/$(COMPONENT_ARCHIVE)
 COMPONENT_BUGDB=	utility/wireshark
 
-TPNO=			21136
+TPNO=			21482
 
 include $(WS_MAKE_RULES)/prep.mk
 include $(WS_MAKE_RULES)/configure.mk
@@ -55,14 +55,16 @@
 CONFIGURE_OPTIONS +=	--disable-randpkt
 CONFIGURE_OPTIONS +=	--disable-dftest
 CONFIGURE_OPTIONS +=	--with-krb5
+CONFIGURE_OPTIONS +=	--with-qt=no
+CONFIGURE_OPTIONS +=	--with-gtk2=yes
 CONFIGURE_OPTIONS +=	CFLAGS="$(CFLAGS)" 
 CONFIGURE_OPTIONS +=	PATH="/usr/perl5/bin:/usr/gnu/bin:$(PATH)"
 
 # Use the 64-bit versions of pkg-config files
 CONFIGURE_ENV +=	PKG_CONFIG_PATH="$(PKG_CONFIG_PATH)"
 
-# Version 1.10 (libwireshark.so) doesn't play nicely with -Bdirect.
-LD_B_DIRECT=
+# Workaround for Bug 19143303
+studio_OPT =	-xO3
 
 # We need to avoid RPATH=/usr/lib in Wireshark libraries so that we can
 # create successfully IPS package of different Wireshark branch than is
@@ -77,6 +79,16 @@
 	chmod 755 config.status; \
 	./config.status)
 
+# During install libtool will relink libwireshark library so that it
+# requires libwiretap version from system and not from proto area.
+# This shall be removed once CBE is updated to contain Wireshark 1.12
+# (see Bug 20627618).
+COMPONENT_POST_INSTALL_ACTION = \
+	(/usr/bin/elfdump -d $(PROTO_DIR)/usr/lib/$(MACH64)/libwireshark.so.5.0.3 | \
+	    grep 'libwiretap.so.3' && /usr/bin/elfedit \
+	    -e 'dyn:value -s -with-valstr libwiretap.so.3 libwiretap.so.4' \
+	    $(PROTO_DIR)/usr/lib/$(MACH64)/libwireshark.so.5.0.3)
+
 configure:	$(CONFIGURE_64)
 
 build:		$(BUILD_64)
--- a/components/wireshark/patches/DesktopEntry.patch	Sun Mar 01 10:25:15 2015 -0800
+++ b/components/wireshark/patches/DesktopEntry.patch	Thu Feb 12 06:05:38 2015 -0800
@@ -1,6 +1,11 @@
+Patch origin: in-house
+Patch status: Solaris-specific; not suitable for upstream
+
+Starts Wireshark via pfexec to leverage any given privileges.
+
 --- wireshark.desktop
 +++ wireshark.desktop
[email protected]@ -70,8 +70,8 @@
[email protected]@ -69,8 +69,8 @@
  Comment[fr]=Analyseur de trafic réseau
  Comment[sv]=Nätverkstrafikanalysator
  Icon=wireshark
--- a/components/wireshark/patches/evb.patch	Sun Mar 01 10:25:15 2015 -0800
+++ b/components/wireshark/patches/evb.patch	Thu Feb 12 06:05:38 2015 -0800
@@ -1,8 +1,13 @@
+Patch origin: in-house
+Patch status: Will be sent to upstream.
+
+Oracle Solaris ECP/VDP dissection based on IEEE 802.1Qbg Draft 2.1. 
+
 Index: epan/oui.h
 ===================================================================
 --- epan/oui.h	(revision 41973)
 +++ epan/oui.h	(working copy)
[email protected]@ -47,6 +47,7 @@
[email protected]@ -45,6 +45,7 @@
  #define OUI_ERICSSON        0x0001EC    /* Ericsson Group */
  #define OUI_CATENA          0x00025A    /* Catena Networks */
  #define OUI_ATHEROS         0x00037F    /* Atheros Communications */
@@ -14,7 +19,7 @@
 ===================================================================
 --- epan/etypes.h	(revision 41973)
 +++ epan/etypes.h	(working copy)
[email protected]@ -514,6 +514,10 @@
[email protected]@ -526,6 +526,10 @@
  #define ETHERTYPE_HSR			0x892F  /* High-availability Seamless Redundancy (IEC62439 Part 3) */
  #endif
  
@@ -29,7 +34,7 @@
 ===================================================================
 --- epan/dissectors/packet-ecp.c	(revision 0)
 +++ epan/dissectors/packet-ecp.c	(revision 0)
[email protected]@ -0,0 +1,616 @@
[email protected]@ -0,0 +1,619 @@
 +/* packet-ecp.c
 + * Routines for Solaris ECP/VDP dissection based on IEEE 802.1Qbg Draft 2.1
 + *
@@ -70,6 +75,7 @@
 +static int proto_vdp = -1;
 +static int hf_vdp_tlv_type = -1;
 +static int hf_vdp_tlv_len = -1;
++static int hf_vdp_tlv_len_invalid = -1;
 +static int hf_vdp_tlv_assoc_reason = -1;
 +static int hf_vdp_tlv_org_oui = -1;
 +static int hf_vdp_vsitypeid = -1;
@@ -203,6 +209,12 @@
 +	{ 0x0,				NULL }
 +};
 +
++static const true_false_string tfs_tlv_len_invalid = {
++        "",
++        ""
++};
++
++
 +static void
 +vdp_add_vidstr(tvbuff_t *tvb, proto_tree *tree, guint32 offset, proto_item *ti)
 +{
@@ -304,7 +316,7 @@
 +		offset++;
 +
 +		/* VSIID */
-+		str = tvb_bytes_to_str_punct(tvb, offset, 16, ':');
++		str = tvb_bytes_to_ep_str_punct(tvb, offset, 16, ':');
 +		proto_tree_add_text(vdp_tlv_assoc_tree, tvb, offset, 16,
 +		    "VSIID: %s", str);
 +		offset += 16;
@@ -356,10 +368,7 @@
 +	tlvlen = TLV_INFO_LEN(tlvhdr);
 +	if (tlvlen != 16) {
 +		if (tree) {
-+			proto_tree_add_text(vdp_tlv_mgrid_tree, tvb, offset, 2,
-+			    "%s Invalid Length: %u",
-+			    decode_boolean_bitfield(tlvlen, TLV_INFO_LEN_MASK,
-+			    16, "", ""), tlvlen);
++			proto_tree_add_boolean(vdp_tlv_mgrid_tree, hf_vdp_tlv_len_invalid, tvb, offset, 2, tlvlen);
 +		}
 +		return -1;
 +	}
@@ -399,10 +408,7 @@
 +	tlvlen = TLV_INFO_LEN(tlvhdr);
 +	if (tlvlen < 3) {
 +		if (tree) {
-+			proto_tree_add_text(tree, tvb, offset, 2,
-+			    "%s Invalid Length: %u",
-+			    decode_boolean_bitfield(tlvlen, TLV_INFO_LEN_MASK,
-+			    16, "", ""), tlvlen);
++			proto_tree_add_boolean(tree, hf_vdp_tlv_len_invalid, tvb, offset, 2, tlvlen);
 +		}
 +		return -1;
 +	}
@@ -504,11 +510,10 @@
 +	ver = ECP_VERSION(hdr);
 +	op = ECP_OP(hdr);
 +	subtype = ECP_SUBTYPE(hdr);
-+	if (check_col(pinfo->cinfo, COL_INFO)) {
-+		col_append_fstr(pinfo->cinfo, COL_INFO,
-+		    "PDU Version = %x OP = %x"
-+		    " Subtype = %x", ver, op, subtype);
-+	}
++	col_append_fstr(pinfo->cinfo, COL_INFO,
++	    "PDU Version = %x OP = %x"
++	    " Subtype = %x", ver, op, subtype);
++
 +	if (tree) {
 +		/* details */
 +		ti = proto_tree_add_item(tree, proto_ecp, tvb, 0, -1, ENC_NA);
@@ -572,7 +577,10 @@
 +		{ &hf_vdp_tlv_len,
 +		{ "VDP TLV Length",	"vdp.tlvlen", FT_UINT16, BASE_DEC,
 +			NULL, TLV_INFO_LEN_MASK, NULL, HFILL }},
-+
++		{ &hf_vdp_tlv_len_invalid,
++		{ "VDP TLV Invalid Length", "vdp.tlvlen_invalid", FT_BOOLEAN,
++		    	16, TFS(&tfs_tlv_len_invalid), TLV_INFO_LEN_MASK,
++			NULL, HFILL}},
 +		{ &hf_vdp_tlv_assoc_reason,
 +		{ "Reason/Status",	"vdp.assoc.reason", FT_UINT8, BASE_HEX,
 +			NULL, 0x0, NULL, HFILL }},
@@ -650,11 +658,11 @@
 ===================================================================
 --- epan/dissectors/Makefile.common	(revision 41973)
 +++ epan/dissectors/Makefile.common	(working copy)
[email protected]@ -114,6 +114,7 @@
- 	packet-dop.c \
- 	packet-dsp.c \
- 	packet-ess.c \
-+	packet-ecp.c \
- 	packet-ftam.c \
- 	packet-goose.c \
- 	packet-HI2Operations.c \
[email protected]@ -118,6 +118,7 @@
+ 	packet-dop.c	\
+ 	packet-dsp.c	\
+ 	packet-ess.c	\
++	packet-ecp.c	\
+ 	packet-ftam.c	\
+ 	packet-goose.c	\
+ 	packet-HI2Operations.c	\
--- a/components/wireshark/patches/man.patch	Sun Mar 01 10:25:15 2015 -0800
+++ b/components/wireshark/patches/man.patch	Thu Feb 12 06:05:38 2015 -0800
@@ -1,6 +1,11 @@
+Patch origin: in-house
+Patch status: Solaris-specific; not suitable for upstream
+
+Solaris specific documentation changes.
+
 --- doc/tshark.pod
 +++ doc/tshark.pod
[email protected]@ -449,9 +449,9 @@
[email protected]@ -478,9 +478,9 @@
  
  Network interface names should match one of the names listed in
  "B<tshark -D>" (described above); a number, as reported by
@@ -13,7 +18,7 @@
  
  If no interface is specified, B<TShark> searches the list of
  interfaces, choosing the first non-loopback interface if there are any
[email protected]@ -1403,7 +1403,7 @@
[email protected]@ -1469,7 +1469,7 @@
  
  =head1 CAPTURE FILTER SYNTAX
  
@@ -22,7 +27,7 @@
  or, if that doesn't exist, L<http://wiki.wireshark.org/CaptureFilters>.
  
  =head1 READ FILTER SYNTAX
[email protected]@ -1672,7 +1672,7 @@
[email protected]@ -1756,7 +1756,7 @@
  =head1 SEE ALSO
  
  wireshark-filter(4), wireshark(1), editcap(1), pcap(3), dumpcap(1),
@@ -46,7 +51,7 @@
  
  If no interface is specified, B<Wireshark> searches the list of
  interfaces, choosing the first non-loopback interface if there are any
[email protected]@ -2457,7 +2457,7 @@
[email protected]@ -2476,7 +2476,7 @@
  
  =head1 CAPTURE FILTER SYNTAX
  
@@ -55,7 +60,7 @@
  or, if that doesn't exist, L<http://wiki.wireshark.org/CaptureFilters>.
  
  =head1 DISPLAY FILTER SYNTAX
[email protected]@ -2837,7 +2837,7 @@
[email protected]@ -2874,7 +2874,7 @@
  =head1 SEE ALSO
  
  wireshark-filter(4), tshark(1), editcap(1), pcap(3), dumpcap(1), mergecap(1),
@@ -77,7 +82,7 @@
  
 --- doc/dumpcap.pod
 +++ doc/dumpcap.pod
[email protected]@ -342,13 +342,13 @@
[email protected]@ -349,13 +349,13 @@
  
  =head1 CAPTURE FILTER SYNTAX
  
@@ -95,7 +100,7 @@
  
 --- doc/editcap.pod
 +++ doc/editcap.pod
[email protected]@ -339,7 +339,7 @@
[email protected]@ -380,7 +380,7 @@
  =head1 SEE ALSO
  
  pcap(3), wireshark(1), tshark(1), mergecap(1), dumpcap(1), capinfos(1),
@@ -117,7 +122,7 @@
  
 --- doc/rawshark.pod
 +++ doc/rawshark.pod
[email protected]@ -507,7 +507,7 @@
[email protected]@ -546,7 +546,7 @@
  =head1 SEE ALSO
  
  wireshark-filter(4), wireshark(1), tshark(1), editcap(1), pcap(3), dumpcap(1),
@@ -128,7 +133,7 @@
  
 --- doc/text2pcap.pod
 +++ doc/text2pcap.pod
[email protected]@ -223,7 +223,7 @@
[email protected]@ -238,7 +238,7 @@
  =head1 SEE ALSO
  
  od(1), pcap(3), wireshark(1), tshark(1), dumpcap(1), mergecap(1),
--- a/components/wireshark/wireshark-common.p5m	Sun Mar 01 10:25:15 2015 -0800
+++ b/components/wireshark/wireshark-common.p5m	Thu Feb 12 06:05:38 2015 -0800
@@ -37,20 +37,24 @@
 set name=org.opensolaris.consolidation value=$(CONSOLIDATION)
 file exec_attr.dumpcap \
     path=etc/security/exec_attr.d/diagnostic:wireshark:wireshark-common
+link path=usr/lib/$(MACH64)/libfiletap.so \
+    target=libfiletap.so.0.0.$(MICRO_VERSION)
+link path=usr/lib/$(MACH64)/libfiletap.so.0 \
+    target=libfiletap.so.0.0.$(MICRO_VERSION)
+file path=usr/lib/$(MACH64)/libfiletap.so.0.0.$(MICRO_VERSION)
 link path=usr/lib/$(MACH64)/libwireshark.so \
-    target=libwireshark.so.3.1.$(MICRO_VERSION)
-link path=usr/lib/$(MACH64)/libwireshark.so.3 \
-    target=libwireshark.so.3.1.$(MICRO_VERSION)
-file path=usr/lib/$(MACH64)/libwireshark.so.3.1.$(MICRO_VERSION)
+    target=libwireshark.so.5.0.$(MICRO_VERSION)
+link path=usr/lib/$(MACH64)/libwireshark.so.5 \
+    target=libwireshark.so.5.0.$(MICRO_VERSION)
+file path=usr/lib/$(MACH64)/libwireshark.so.5.0.$(MICRO_VERSION)
 link path=usr/lib/$(MACH64)/libwiretap.so \
-    target=libwiretap.so.3.0.$(MICRO_VERSION)
-link path=usr/lib/$(MACH64)/libwiretap.so.3 \
-    target=libwiretap.so.3.0.$(MICRO_VERSION)
-file path=usr/lib/$(MACH64)/libwiretap.so.3.0.$(MICRO_VERSION)
-link path=usr/lib/$(MACH64)/libwsutil.so target=libwsutil.so.3.0.0
-link path=usr/lib/$(MACH64)/libwsutil.so.3 target=libwsutil.so.3.0.0
-file path=usr/lib/$(MACH64)/libwsutil.so.3.0.0
-file path=usr/lib/$(MACH64)/wireshark/plugins/$(IPS_COMPONENT_VERSION)/asn1.so
+    target=libwiretap.so.4.0.$(MICRO_VERSION)
+link path=usr/lib/$(MACH64)/libwiretap.so.4 \
+    target=libwiretap.so.4.0.$(MICRO_VERSION)
+file path=usr/lib/$(MACH64)/libwiretap.so.4.0.$(MICRO_VERSION)
+link path=usr/lib/$(MACH64)/libwsutil.so target=libwsutil.so.4.1.0
+link path=usr/lib/$(MACH64)/libwsutil.so.4 target=libwsutil.so.4.1.0
+file path=usr/lib/$(MACH64)/libwsutil.so.4.1.0
 file path=usr/lib/$(MACH64)/wireshark/plugins/$(IPS_COMPONENT_VERSION)/docsis.so
 file path=usr/lib/$(MACH64)/wireshark/plugins/$(IPS_COMPONENT_VERSION)/ethercat.so
 file path=usr/lib/$(MACH64)/wireshark/plugins/$(IPS_COMPONENT_VERSION)/gryphon.so
@@ -88,14 +92,17 @@
 file path=usr/share/wireshark/diameter/AlcatelLucent.xml
 file path=usr/share/wireshark/diameter/ChinaTelecom.xml
 file path=usr/share/wireshark/diameter/Cisco.xml
+file path=usr/share/wireshark/diameter/Custom.xml
 file path=usr/share/wireshark/diameter/Ericsson.xml
 file path=usr/share/wireshark/diameter/Nokia.xml
 file path=usr/share/wireshark/diameter/NokiaSiemensNetworks.xml
 file path=usr/share/wireshark/diameter/SKT.xml
+file path=usr/share/wireshark/diameter/Starent.xml
 file path=usr/share/wireshark/diameter/TGPPGmb.xml
 file path=usr/share/wireshark/diameter/TGPPRx.xml
 file path=usr/share/wireshark/diameter/TGPPS9.xml
 file path=usr/share/wireshark/diameter/TGPPSh.xml
+file path=usr/share/wireshark/diameter/VerizonWireless.xml
 file path=usr/share/wireshark/diameter/Vodafone.xml
 file path=usr/share/wireshark/diameter/chargecontrol.xml
 file path=usr/share/wireshark/diameter/dictionary.dtd
@@ -148,6 +155,7 @@
 file path=usr/share/wireshark/radius/dictionary.acme
 file path=usr/share/wireshark/radius/dictionary.airespace
 file path=usr/share/wireshark/radius/dictionary.alcatel
+file path=usr/share/wireshark/radius/dictionary.alcatel-lucent.aaa
 file path=usr/share/wireshark/radius/dictionary.alcatel-lucent.xylan
 file path=usr/share/wireshark/radius/dictionary.alcatel.esam
 file path=usr/share/wireshark/radius/dictionary.alcatel.sr