4048 cpu_acpi is too verbose about disabled SpeedStep/PowerNow! support
Reviewed by: Albert Lee <
[email protected]>
Reviewed by: Garrett D'Amore <
[email protected]>
Approved by: Dan McDonald <
[email protected]>
--- a/usr/src/uts/i86pc/os/cpupm/cpu_acpi.c Tue Aug 27 15:15:40 2013 -0400
+++ b/usr/src/uts/i86pc/os/cpupm/cpu_acpi.c Thu Aug 29 02:06:39 2013 +0400
@@ -441,10 +441,6 @@
if (astatus == AE_NOT_FOUND) {
DTRACE_PROBE3(cpu_acpi__eval__err, int, handle->cs_id,
int, objtype, int, astatus);
- if (objtype == PSS_OBJ)
- cmn_err(CE_NOTE, "!cpu_acpi: _PSS package "
- "evaluation failed for with status %d for "
- "CPU %d.", astatus, handle->cs_id);
return (1);
}
cmn_err(CE_NOTE, "!cpu_acpi: error %d evaluating %s package "
@@ -840,24 +836,18 @@
if (cpu_acpi_cache_pct(handle) < 0) {
DTRACE_PROBE2(cpu_acpi__cache__err, int, handle->cs_id,
int, PCT_OBJ);
- cmn_err(CE_NOTE, "!cpu_acpi: error parsing _PCT for "
- "CPU %d", handle->cs_id);
return (-1);
}
if (cpu_acpi_cache_pstates(handle) != 0) {
DTRACE_PROBE2(cpu_acpi__cache__err, int, handle->cs_id,
int, PSS_OBJ);
- cmn_err(CE_NOTE, "!cpu_acpi: error parsing _PSS for "
- "CPU %d", handle->cs_id);
return (-1);
}
if (cpu_acpi_cache_psd(handle) < 0) {
DTRACE_PROBE2(cpu_acpi__cache__err, int, handle->cs_id,
int, PSD_OBJ);
- cmn_err(CE_NOTE, "!cpu_acpi: error parsing _PSD for "
- "CPU %d", handle->cs_id);
return (-1);
}
--- a/usr/src/uts/i86pc/os/cpupm/pwrnow.c Tue Aug 27 15:15:40 2013 -0400
+++ b/usr/src/uts/i86pc/os/cpupm/pwrnow.c Thu Aug 29 02:06:39 2013 +0400
@@ -170,6 +170,7 @@
(cpupm_mach_state_t *)cp->cpu_m.mcpu_pm_mach_state;
cpu_acpi_handle_t handle = mach_state->ms_acpi_handle;
cpu_acpi_pct_t *pct_stat;
+ static int logged = 0;
PWRNOW_DEBUG(("pwrnow_init: processor %d\n", cp->cpu_id));
@@ -177,9 +178,12 @@
* Cache the P-state specific ACPI data.
*/
if (cpu_acpi_cache_pstate_data(handle) != 0) {
- cmn_err(CE_NOTE, "!PowerNow! support is being "
- "disabled due to errors parsing ACPI P-state objects "
- "exported by BIOS.");
+ if (!logged) {
+ cmn_err(CE_NOTE, "!PowerNow! support is being "
+ "disabled due to errors parsing ACPI P-state "
+ "objects exported by BIOS.");
+ logged = 1;
+ }
pwrnow_fini(cp);
return (PWRNOW_RET_NO_PM);
}
--- a/usr/src/uts/i86pc/os/cpupm/speedstep.c Tue Aug 27 15:15:40 2013 -0400
+++ b/usr/src/uts/i86pc/os/cpupm/speedstep.c Thu Aug 29 02:06:39 2013 +0400
@@ -185,6 +185,7 @@
(cpupm_mach_state_t *)cp->cpu_m.mcpu_pm_mach_state;
cpu_acpi_handle_t handle = mach_state->ms_acpi_handle;
cpu_acpi_pct_t *pct_stat;
+ static int logged = 0;
ESSDEBUG(("speedstep_init: processor %d\n", cp->cpu_id));
@@ -192,9 +193,12 @@
* Cache the P-state specific ACPI data.
*/
if (cpu_acpi_cache_pstate_data(handle) != 0) {
- cmn_err(CE_NOTE, "!SpeedStep support is being "
- "disabled due to errors parsing ACPI P-state objects "
- "exported by BIOS.");
+ if (!logged) {
+ cmn_err(CE_NOTE, "!SpeedStep support is being "
+ "disabled due to errors parsing ACPI P-state "
+ "objects exported by BIOS.");
+ logged = 1;
+ }
speedstep_fini(cp);
return (ESS_RET_NO_PM);
}