patches/gnome-vfs-13-hal-crash.diff
author yippi
Mon, 27 Sep 2010 21:07:51 +0000
changeset 20108 51df67ca9307
parent 11240 bbaacc8e04a9
permissions -rw-r--r--
I had these modules listed as being owned by me, but they are really owned by wangke, correcting.
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
11240
bbaacc8e04a9 2007-11-26 Padraig O'Briain <[email protected]>
padraig
parents:
diff changeset
     1
--- /usr/tmp/clean/gnome-vfs-2.20.1/libgnomevfs/gnome-vfs-hal-mounts.c	2007-11-12 08:36:48.000000000 +0000
bbaacc8e04a9 2007-11-26 Padraig O'Briain <[email protected]>
padraig
parents:
diff changeset
     2
+++ gnome-vfs-2.20.1/libgnomevfs/gnome-vfs-hal-mounts.c	2007-11-23 10:49:55.844493000 +0000
bbaacc8e04a9 2007-11-26 Padraig O'Briain <[email protected]>
padraig
parents:
diff changeset
     3
@@ -1469,8 +1469,12 @@
bbaacc8e04a9 2007-11-26 Padraig O'Briain <[email protected]>
padraig
parents:
diff changeset
     4
 						 _hal_device_property_modified);
bbaacc8e04a9 2007-11-26 Padraig O'Briain <[email protected]>
padraig
parents:
diff changeset
     5
 
bbaacc8e04a9 2007-11-26 Padraig O'Briain <[email protected]>
padraig
parents:
diff changeset
     6
 	if (!libhal_ctx_init (volume_monitor_daemon->hal_ctx, &error)) {
bbaacc8e04a9 2007-11-26 Padraig O'Briain <[email protected]>
padraig
parents:
diff changeset
     7
-		g_warning ("libhal_ctx_init failed: %s\n", error.message);
bbaacc8e04a9 2007-11-26 Padraig O'Briain <[email protected]>
padraig
parents:
diff changeset
     8
-		dbus_error_free (&error);
bbaacc8e04a9 2007-11-26 Padraig O'Briain <[email protected]>
padraig
parents:
diff changeset
     9
+		if (dbus_error_is_set (&error)) {
bbaacc8e04a9 2007-11-26 Padraig O'Briain <[email protected]>
padraig
parents:
diff changeset
    10
+			g_warning ("libhal_ctx_init failed: %s\n", error.message);
bbaacc8e04a9 2007-11-26 Padraig O'Briain <[email protected]>
padraig
parents:
diff changeset
    11
+			dbus_error_free (&error);
bbaacc8e04a9 2007-11-26 Padraig O'Briain <[email protected]>
padraig
parents:
diff changeset
    12
+		} else {
bbaacc8e04a9 2007-11-26 Padraig O'Briain <[email protected]>
padraig
parents:
diff changeset
    13
+			g_warning ("libhal_ctx_init failed but dbus error is not set\n");
bbaacc8e04a9 2007-11-26 Padraig O'Briain <[email protected]>
padraig
parents:
diff changeset
    14
+		}
bbaacc8e04a9 2007-11-26 Padraig O'Briain <[email protected]>
padraig
parents:
diff changeset
    15
 		return FALSE;
bbaacc8e04a9 2007-11-26 Padraig O'Briain <[email protected]>
padraig
parents:
diff changeset
    16
 	}
bbaacc8e04a9 2007-11-26 Padraig O'Briain <[email protected]>
padraig
parents:
diff changeset
    17
 
bbaacc8e04a9 2007-11-26 Padraig O'Briain <[email protected]>
padraig
parents:
diff changeset
    18
@@ -1499,8 +1503,12 @@
bbaacc8e04a9 2007-11-26 Padraig O'Briain <[email protected]>
padraig
parents:
diff changeset
    19
 
bbaacc8e04a9 2007-11-26 Padraig O'Briain <[email protected]>
padraig
parents:
diff changeset
    20
 	dbus_error_init (&error);
bbaacc8e04a9 2007-11-26 Padraig O'Briain <[email protected]>
padraig
parents:
diff changeset
    21
 	if (!libhal_ctx_shutdown (volume_monitor_daemon->hal_ctx, &error)) {
bbaacc8e04a9 2007-11-26 Padraig O'Briain <[email protected]>
padraig
parents:
diff changeset
    22
-		g_warning ("hal_shutdown failed: %s\n", error.message);
bbaacc8e04a9 2007-11-26 Padraig O'Briain <[email protected]>
padraig
parents:
diff changeset
    23
-		dbus_error_free (&error);
bbaacc8e04a9 2007-11-26 Padraig O'Briain <[email protected]>
padraig
parents:
diff changeset
    24
+		if (dbus_error_is_set (&error)) {
bbaacc8e04a9 2007-11-26 Padraig O'Briain <[email protected]>
padraig
parents:
diff changeset
    25
+			g_warning ("hal_shutdown failed: %s\n", error.message);
bbaacc8e04a9 2007-11-26 Padraig O'Briain <[email protected]>
padraig
parents:
diff changeset
    26
+			dbus_error_free (&error);
bbaacc8e04a9 2007-11-26 Padraig O'Briain <[email protected]>
padraig
parents:
diff changeset
    27
+		} else {
bbaacc8e04a9 2007-11-26 Padraig O'Briain <[email protected]>
padraig
parents:
diff changeset
    28
+			g_warning ("hal_shutdown failed but dbus error is not set\n");
bbaacc8e04a9 2007-11-26 Padraig O'Briain <[email protected]>
padraig
parents:
diff changeset
    29
+		}
bbaacc8e04a9 2007-11-26 Padraig O'Briain <[email protected]>
padraig
parents:
diff changeset
    30
 		return;
bbaacc8e04a9 2007-11-26 Padraig O'Briain <[email protected]>
padraig
parents:
diff changeset
    31
 	}
bbaacc8e04a9 2007-11-26 Padraig O'Briain <[email protected]>
padraig
parents:
diff changeset
    32