| author | Jiri Sasek <Jiri.Sasek@Oracle.COM> |
| Wed, 04 May 2016 14:21:51 -0700 | |
| changeset 5920 | 1e847165fde2 |
| parent 1885 | 2572673471ef |
| permissions | -rw-r--r-- |
|
1885
2572673471ef
18450560 /usr/bin/grops dumps core with invalid argument value
Rich Burridge <rich.burridge@oracle.com>
parents:
diff
changeset
|
1 |
Prevent /usr/bin/grops from dumping core with given an invalid argument value |
|
2572673471ef
18450560 /usr/bin/grops dumps core with invalid argument value
Rich Burridge <rich.burridge@oracle.com>
parents:
diff
changeset
|
2 |
with something such as |
|
2572673471ef
18450560 /usr/bin/grops dumps core with invalid argument value
Rich Burridge <rich.burridge@oracle.com>
parents:
diff
changeset
|
3 |
|
|
2572673471ef
18450560 /usr/bin/grops dumps core with invalid argument value
Rich Burridge <rich.burridge@oracle.com>
parents:
diff
changeset
|
4 |
$ /usr/bin/grops -c a |
|
2572673471ef
18450560 /usr/bin/grops dumps core with invalid argument value
Rich Burridge <rich.burridge@oracle.com>
parents:
diff
changeset
|
5 |
|
|
2572673471ef
18450560 /usr/bin/grops dumps core with invalid argument value
Rich Burridge <rich.burridge@oracle.com>
parents:
diff
changeset
|
6 |
Fix has been submitted upstream: |
|
2572673471ef
18450560 /usr/bin/grops dumps core with invalid argument value
Rich Burridge <rich.burridge@oracle.com>
parents:
diff
changeset
|
7 |
http://savannah.gnu.org/bugs/?42190 |
|
2572673471ef
18450560 /usr/bin/grops dumps core with invalid argument value
Rich Burridge <rich.burridge@oracle.com>
parents:
diff
changeset
|
8 |
|
|
2572673471ef
18450560 /usr/bin/grops dumps core with invalid argument value
Rich Burridge <rich.burridge@oracle.com>
parents:
diff
changeset
|
9 |
--- groff-1.22.2/src/devices/grops/ps.cpp.orig 2014-04-24 06:01:32.421674773 -0700 |
|
2572673471ef
18450560 /usr/bin/grops dumps core with invalid argument value
Rich Burridge <rich.burridge@oracle.com>
parents:
diff
changeset
|
10 |
+++ groff-1.22.2/src/devices/grops/ps.cpp 2014-04-24 09:27:56.445423217 -0700 |
|
2572673471ef
18450560 /usr/bin/grops dumps core with invalid argument value
Rich Burridge <rich.burridge@oracle.com>
parents:
diff
changeset
|
11 |
@@ -1803,7 +1803,7 @@ |
|
2572673471ef
18450560 /usr/bin/grops dumps core with invalid argument value
Rich Burridge <rich.burridge@oracle.com>
parents:
diff
changeset
|
12 |
break; |
|
2572673471ef
18450560 /usr/bin/grops dumps core with invalid argument value
Rich Burridge <rich.burridge@oracle.com>
parents:
diff
changeset
|
13 |
case 'c': |
|
2572673471ef
18450560 /usr/bin/grops dumps core with invalid argument value
Rich Burridge <rich.burridge@oracle.com>
parents:
diff
changeset
|
14 |
if (sscanf(optarg, "%d", &ncopies) != 1 || ncopies <= 0) {
|
|
2572673471ef
18450560 /usr/bin/grops dumps core with invalid argument value
Rich Burridge <rich.burridge@oracle.com>
parents:
diff
changeset
|
15 |
- error("bad number of copies `%s'", optarg);
|
|
2572673471ef
18450560 /usr/bin/grops dumps core with invalid argument value
Rich Burridge <rich.burridge@oracle.com>
parents:
diff
changeset
|
16 |
+ error("bad number of copies `%1'", optarg);
|
|
2572673471ef
18450560 /usr/bin/grops dumps core with invalid argument value
Rich Burridge <rich.burridge@oracle.com>
parents:
diff
changeset
|
17 |
ncopies = 1; |
|
2572673471ef
18450560 /usr/bin/grops dumps core with invalid argument value
Rich Burridge <rich.burridge@oracle.com>
parents:
diff
changeset
|
18 |
} |
|
2572673471ef
18450560 /usr/bin/grops dumps core with invalid argument value
Rich Burridge <rich.burridge@oracle.com>
parents:
diff
changeset
|
19 |
break; |