author | Lijo George<lijo.x.george@oracle.com> |
Tue, 18 Apr 2017 03:03:20 -0700 | |
branch | s11u3-sru |
changeset 7891 | 95cc369493f9 |
parent 7535 | 6be40da83c51 |
permissions | -rw-r--r-- |
7535
6be40da83c51
24571490 /usr/sbin/ntp-keygen crashes with SIGSEGV
Brian Utterback <brian.utterback@oracle.com>
parents:
diff
changeset
|
1 |
This bug has been reported as NTP community bug 3103 zsave_warn format string |
6be40da83c51
24571490 /usr/sbin/ntp-keygen crashes with SIGSEGV
Brian Utterback <brian.utterback@oracle.com>
parents:
diff
changeset
|
2 |
used without arguments. |
6be40da83c51
24571490 /usr/sbin/ntp-keygen crashes with SIGSEGV
Brian Utterback <brian.utterback@oracle.com>
parents:
diff
changeset
|
3 |
http://bugs.ntp.org/show_bug.cgi?id=3103 |
6be40da83c51
24571490 /usr/sbin/ntp-keygen crashes with SIGSEGV
Brian Utterback <brian.utterback@oracle.com>
parents:
diff
changeset
|
4 |
This patch may be removed after upgrading to a version of NTP that has |
6be40da83c51
24571490 /usr/sbin/ntp-keygen crashes with SIGSEGV
Brian Utterback <brian.utterback@oracle.com>
parents:
diff
changeset
|
5 |
bug 3103 fixed. |
6be40da83c51
24571490 /usr/sbin/ntp-keygen crashes with SIGSEGV
Brian Utterback <brian.utterback@oracle.com>
parents:
diff
changeset
|
6 |
|
6be40da83c51
24571490 /usr/sbin/ntp-keygen crashes with SIGSEGV
Brian Utterback <brian.utterback@oracle.com>
parents:
diff
changeset
|
7 |
*** sntp/libopts/save.c |
6be40da83c51
24571490 /usr/sbin/ntp-keygen crashes with SIGSEGV
Brian Utterback <brian.utterback@oracle.com>
parents:
diff
changeset
|
8 |
--- sntp/libopts/save.c |
6be40da83c51
24571490 /usr/sbin/ntp-keygen crashes with SIGSEGV
Brian Utterback <brian.utterback@oracle.com>
parents:
diff
changeset
|
9 |
*************** find_dir_name(tOptions * opts, int * p_f |
6be40da83c51
24571490 /usr/sbin/ntp-keygen crashes with SIGSEGV
Brian Utterback <brian.utterback@oracle.com>
parents:
diff
changeset
|
10 |
*** 128,134 **** |
6be40da83c51
24571490 /usr/sbin/ntp-keygen crashes with SIGSEGV
Brian Utterback <brian.utterback@oracle.com>
parents:
diff
changeset
|
11 |
} |
6be40da83c51
24571490 /usr/sbin/ntp-keygen crashes with SIGSEGV
Brian Utterback <brian.utterback@oracle.com>
parents:
diff
changeset
|
12 |
|
6be40da83c51
24571490 /usr/sbin/ntp-keygen crashes with SIGSEGV
Brian Utterback <brian.utterback@oracle.com>
parents:
diff
changeset
|
13 |
if (pzEnv == NULL) { |
6be40da83c51
24571490 /usr/sbin/ntp-keygen crashes with SIGSEGV
Brian Utterback <brian.utterback@oracle.com>
parents:
diff
changeset
|
14 |
! fprintf(stderr, zsave_warn, opts->pzProgName); |
6be40da83c51
24571490 /usr/sbin/ntp-keygen crashes with SIGSEGV
Brian Utterback <brian.utterback@oracle.com>
parents:
diff
changeset
|
15 |
fprintf(stderr, zNotDef, pzDir); |
6be40da83c51
24571490 /usr/sbin/ntp-keygen crashes with SIGSEGV
Brian Utterback <brian.utterback@oracle.com>
parents:
diff
changeset
|
16 |
return NULL; |
6be40da83c51
24571490 /usr/sbin/ntp-keygen crashes with SIGSEGV
Brian Utterback <brian.utterback@oracle.com>
parents:
diff
changeset
|
17 |
} |
6be40da83c51
24571490 /usr/sbin/ntp-keygen crashes with SIGSEGV
Brian Utterback <brian.utterback@oracle.com>
parents:
diff
changeset
|
18 |
--- 128,134 ---- |
6be40da83c51
24571490 /usr/sbin/ntp-keygen crashes with SIGSEGV
Brian Utterback <brian.utterback@oracle.com>
parents:
diff
changeset
|
19 |
} |
6be40da83c51
24571490 /usr/sbin/ntp-keygen crashes with SIGSEGV
Brian Utterback <brian.utterback@oracle.com>
parents:
diff
changeset
|
20 |
|
6be40da83c51
24571490 /usr/sbin/ntp-keygen crashes with SIGSEGV
Brian Utterback <brian.utterback@oracle.com>
parents:
diff
changeset
|
21 |
if (pzEnv == NULL) { |
6be40da83c51
24571490 /usr/sbin/ntp-keygen crashes with SIGSEGV
Brian Utterback <brian.utterback@oracle.com>
parents:
diff
changeset
|
22 |
! fprintf(stderr, zsave_warn, opts->pzProgName, "\"\""); |
6be40da83c51
24571490 /usr/sbin/ntp-keygen crashes with SIGSEGV
Brian Utterback <brian.utterback@oracle.com>
parents:
diff
changeset
|
23 |
fprintf(stderr, zNotDef, pzDir); |
6be40da83c51
24571490 /usr/sbin/ntp-keygen crashes with SIGSEGV
Brian Utterback <brian.utterback@oracle.com>
parents:
diff
changeset
|
24 |
return NULL; |
6be40da83c51
24571490 /usr/sbin/ntp-keygen crashes with SIGSEGV
Brian Utterback <brian.utterback@oracle.com>
parents:
diff
changeset
|
25 |
} |
6be40da83c51
24571490 /usr/sbin/ntp-keygen crashes with SIGSEGV
Brian Utterback <brian.utterback@oracle.com>
parents:
diff
changeset
|
26 |
*************** find_file_name(tOptions * opts, int * p_ |
6be40da83c51
24571490 /usr/sbin/ntp-keygen crashes with SIGSEGV
Brian Utterback <brian.utterback@oracle.com>
parents:
diff
changeset
|
27 |
*** 180,186 **** |
6be40da83c51
24571490 /usr/sbin/ntp-keygen crashes with SIGSEGV
Brian Utterback <brian.utterback@oracle.com>
parents:
diff
changeset
|
28 |
*/ |
6be40da83c51
24571490 /usr/sbin/ntp-keygen crashes with SIGSEGV
Brian Utterback <brian.utterback@oracle.com>
parents:
diff
changeset
|
29 |
if (errno != ENOENT) { |
6be40da83c51
24571490 /usr/sbin/ntp-keygen crashes with SIGSEGV
Brian Utterback <brian.utterback@oracle.com>
parents:
diff
changeset
|
30 |
bogus_name: |
6be40da83c51
24571490 /usr/sbin/ntp-keygen crashes with SIGSEGV
Brian Utterback <brian.utterback@oracle.com>
parents:
diff
changeset
|
31 |
! fprintf(stderr, zsave_warn, opts->pzProgName); |
6be40da83c51
24571490 /usr/sbin/ntp-keygen crashes with SIGSEGV
Brian Utterback <brian.utterback@oracle.com>
parents:
diff
changeset
|
32 |
fprintf(stderr, zNoStat, errno, strerror(errno), pzDir); |
6be40da83c51
24571490 /usr/sbin/ntp-keygen crashes with SIGSEGV
Brian Utterback <brian.utterback@oracle.com>
parents:
diff
changeset
|
33 |
if (free_dir_name) |
6be40da83c51
24571490 /usr/sbin/ntp-keygen crashes with SIGSEGV
Brian Utterback <brian.utterback@oracle.com>
parents:
diff
changeset
|
34 |
AGFREE(pzDir); |
6be40da83c51
24571490 /usr/sbin/ntp-keygen crashes with SIGSEGV
Brian Utterback <brian.utterback@oracle.com>
parents:
diff
changeset
|
35 |
--- 180,186 ---- |
6be40da83c51
24571490 /usr/sbin/ntp-keygen crashes with SIGSEGV
Brian Utterback <brian.utterback@oracle.com>
parents:
diff
changeset
|
36 |
*/ |
6be40da83c51
24571490 /usr/sbin/ntp-keygen crashes with SIGSEGV
Brian Utterback <brian.utterback@oracle.com>
parents:
diff
changeset
|
37 |
if (errno != ENOENT) { |
6be40da83c51
24571490 /usr/sbin/ntp-keygen crashes with SIGSEGV
Brian Utterback <brian.utterback@oracle.com>
parents:
diff
changeset
|
38 |
bogus_name: |
6be40da83c51
24571490 /usr/sbin/ntp-keygen crashes with SIGSEGV
Brian Utterback <brian.utterback@oracle.com>
parents:
diff
changeset
|
39 |
! fprintf(stderr, zsave_warn, opts->pzProgName,pzDir); |
6be40da83c51
24571490 /usr/sbin/ntp-keygen crashes with SIGSEGV
Brian Utterback <brian.utterback@oracle.com>
parents:
diff
changeset
|
40 |
fprintf(stderr, zNoStat, errno, strerror(errno), pzDir); |
6be40da83c51
24571490 /usr/sbin/ntp-keygen crashes with SIGSEGV
Brian Utterback <brian.utterback@oracle.com>
parents:
diff
changeset
|
41 |
if (free_dir_name) |
6be40da83c51
24571490 /usr/sbin/ntp-keygen crashes with SIGSEGV
Brian Utterback <brian.utterback@oracle.com>
parents:
diff
changeset
|
42 |
AGFREE(pzDir); |
6be40da83c51
24571490 /usr/sbin/ntp-keygen crashes with SIGSEGV
Brian Utterback <brian.utterback@oracle.com>
parents:
diff
changeset
|
43 |
*************** find_file_name(tOptions * opts, int * p_ |
6be40da83c51
24571490 /usr/sbin/ntp-keygen crashes with SIGSEGV
Brian Utterback <brian.utterback@oracle.com>
parents:
diff
changeset
|
44 |
*** 234,240 **** |
6be40da83c51
24571490 /usr/sbin/ntp-keygen crashes with SIGSEGV
Brian Utterback <brian.utterback@oracle.com>
parents:
diff
changeset
|
45 |
*/ |
6be40da83c51
24571490 /usr/sbin/ntp-keygen crashes with SIGSEGV
Brian Utterback <brian.utterback@oracle.com>
parents:
diff
changeset
|
46 |
if (stat(pzDir, &stBuf) != 0) { |
6be40da83c51
24571490 /usr/sbin/ntp-keygen crashes with SIGSEGV
Brian Utterback <brian.utterback@oracle.com>
parents:
diff
changeset
|
47 |
if (errno != ENOENT) { |
6be40da83c51
24571490 /usr/sbin/ntp-keygen crashes with SIGSEGV
Brian Utterback <brian.utterback@oracle.com>
parents:
diff
changeset
|
48 |
! fprintf(stderr, zsave_warn, opts->pzProgName); |
6be40da83c51
24571490 /usr/sbin/ntp-keygen crashes with SIGSEGV
Brian Utterback <brian.utterback@oracle.com>
parents:
diff
changeset
|
49 |
fprintf(stderr, zNoStat, errno, strerror(errno), |
6be40da83c51
24571490 /usr/sbin/ntp-keygen crashes with SIGSEGV
Brian Utterback <brian.utterback@oracle.com>
parents:
diff
changeset
|
50 |
pzDir); |
6be40da83c51
24571490 /usr/sbin/ntp-keygen crashes with SIGSEGV
Brian Utterback <brian.utterback@oracle.com>
parents:
diff
changeset
|
51 |
AGFREE(pzDir); |
6be40da83c51
24571490 /usr/sbin/ntp-keygen crashes with SIGSEGV
Brian Utterback <brian.utterback@oracle.com>
parents:
diff
changeset
|
52 |
--- 234,240 ---- |
6be40da83c51
24571490 /usr/sbin/ntp-keygen crashes with SIGSEGV
Brian Utterback <brian.utterback@oracle.com>
parents:
diff
changeset
|
53 |
*/ |
6be40da83c51
24571490 /usr/sbin/ntp-keygen crashes with SIGSEGV
Brian Utterback <brian.utterback@oracle.com>
parents:
diff
changeset
|
54 |
if (stat(pzDir, &stBuf) != 0) { |
6be40da83c51
24571490 /usr/sbin/ntp-keygen crashes with SIGSEGV
Brian Utterback <brian.utterback@oracle.com>
parents:
diff
changeset
|
55 |
if (errno != ENOENT) { |
6be40da83c51
24571490 /usr/sbin/ntp-keygen crashes with SIGSEGV
Brian Utterback <brian.utterback@oracle.com>
parents:
diff
changeset
|
56 |
! fprintf(stderr, zsave_warn, opts->pzProgName, pzDir); |
6be40da83c51
24571490 /usr/sbin/ntp-keygen crashes with SIGSEGV
Brian Utterback <brian.utterback@oracle.com>
parents:
diff
changeset
|
57 |
fprintf(stderr, zNoStat, errno, strerror(errno), |
6be40da83c51
24571490 /usr/sbin/ntp-keygen crashes with SIGSEGV
Brian Utterback <brian.utterback@oracle.com>
parents:
diff
changeset
|
58 |
pzDir); |
6be40da83c51
24571490 /usr/sbin/ntp-keygen crashes with SIGSEGV
Brian Utterback <brian.utterback@oracle.com>
parents:
diff
changeset
|
59 |
AGFREE(pzDir); |
6be40da83c51
24571490 /usr/sbin/ntp-keygen crashes with SIGSEGV
Brian Utterback <brian.utterback@oracle.com>
parents:
diff
changeset
|
60 |
*************** open_sv_file(tOptions * opts) |
6be40da83c51
24571490 /usr/sbin/ntp-keygen crashes with SIGSEGV
Brian Utterback <brian.utterback@oracle.com>
parents:
diff
changeset
|
61 |
*** 531,537 **** |
6be40da83c51
24571490 /usr/sbin/ntp-keygen crashes with SIGSEGV
Brian Utterback <brian.utterback@oracle.com>
parents:
diff
changeset
|
62 |
|
6be40da83c51
24571490 /usr/sbin/ntp-keygen crashes with SIGSEGV
Brian Utterback <brian.utterback@oracle.com>
parents:
diff
changeset
|
63 |
fp = fopen(pzFName, "w" FOPEN_BINARY_FLAG); |
6be40da83c51
24571490 /usr/sbin/ntp-keygen crashes with SIGSEGV
Brian Utterback <brian.utterback@oracle.com>
parents:
diff
changeset
|
64 |
if (fp == NULL) { |
6be40da83c51
24571490 /usr/sbin/ntp-keygen crashes with SIGSEGV
Brian Utterback <brian.utterback@oracle.com>
parents:
diff
changeset
|
65 |
! fprintf(stderr, zsave_warn, opts->pzProgName); |
6be40da83c51
24571490 /usr/sbin/ntp-keygen crashes with SIGSEGV
Brian Utterback <brian.utterback@oracle.com>
parents:
diff
changeset
|
66 |
fprintf(stderr, zNoCreat, errno, strerror(errno), pzFName); |
6be40da83c51
24571490 /usr/sbin/ntp-keygen crashes with SIGSEGV
Brian Utterback <brian.utterback@oracle.com>
parents:
diff
changeset
|
67 |
if (free_name) |
6be40da83c51
24571490 /usr/sbin/ntp-keygen crashes with SIGSEGV
Brian Utterback <brian.utterback@oracle.com>
parents:
diff
changeset
|
68 |
AGFREE(pzFName); |
6be40da83c51
24571490 /usr/sbin/ntp-keygen crashes with SIGSEGV
Brian Utterback <brian.utterback@oracle.com>
parents:
diff
changeset
|
69 |
--- 531,537 ---- |
6be40da83c51
24571490 /usr/sbin/ntp-keygen crashes with SIGSEGV
Brian Utterback <brian.utterback@oracle.com>
parents:
diff
changeset
|
70 |
|
6be40da83c51
24571490 /usr/sbin/ntp-keygen crashes with SIGSEGV
Brian Utterback <brian.utterback@oracle.com>
parents:
diff
changeset
|
71 |
fp = fopen(pzFName, "w" FOPEN_BINARY_FLAG); |
6be40da83c51
24571490 /usr/sbin/ntp-keygen crashes with SIGSEGV
Brian Utterback <brian.utterback@oracle.com>
parents:
diff
changeset
|
72 |
if (fp == NULL) { |
6be40da83c51
24571490 /usr/sbin/ntp-keygen crashes with SIGSEGV
Brian Utterback <brian.utterback@oracle.com>
parents:
diff
changeset
|
73 |
! fprintf(stderr, zsave_warn, opts->pzProgName, pzFName); |
6be40da83c51
24571490 /usr/sbin/ntp-keygen crashes with SIGSEGV
Brian Utterback <brian.utterback@oracle.com>
parents:
diff
changeset
|
74 |
fprintf(stderr, zNoCreat, errno, strerror(errno), pzFName); |
6be40da83c51
24571490 /usr/sbin/ntp-keygen crashes with SIGSEGV
Brian Utterback <brian.utterback@oracle.com>
parents:
diff
changeset
|
75 |
if (free_name) |
6be40da83c51
24571490 /usr/sbin/ntp-keygen crashes with SIGSEGV
Brian Utterback <brian.utterback@oracle.com>
parents:
diff
changeset
|
76 |
AGFREE(pzFName); |