components/cyrus-sasl/patches/1-cyrus-sasl-CVE-4122.patch
author Jiri Sasek <Jiri.Sasek@Oracle.COM>
Wed, 26 Apr 2017 14:53:43 -0700
changeset 7954 f5d146a3f5e6
parent 5055 9daf220c1a9a
permissions -rw-r--r--
25598337 Samba 4.4, Win client fails to copy to smb share if it is on NFS with RQUOTA
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
5055
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
     1
This patch was re-made from a commit on cgit.cyrus.foundation at this
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
     2
URL:  
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
     3
https://cgit.cyrus.foundation/cyrus-sasl/commit/?id=dedad73e5e7a75d01a5f3d5a6702ab8ccd2ff40d
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
     4
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
     5
Probably not needed for Solaris but it's better to just have the fix.
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
     6
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
     7
"Handle NULL returns from glibc 2.17+ crypt()
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
     8
Starting with glibc 2.17 (eglibc 2.17), crypt() fails with EINVAL
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
     9
(w/ NULL return) if the salt violates specifications. Additionally,
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    10
on FIPS-140 enabled Linux systems, DES/MD5-encrypted passwords
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    11
passed to crypt() fail with EPERM (w/ NULL return).
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    12
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    13
When using glibc's crypt(), check return value to avoid a possible NULL pointer dereference. Patch by [email protected].
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    14
"
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    15
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    16
diff -rupN old/pwcheck/pwcheck_getpwnam.c new/pwcheck/pwcheck_getpwnam.c
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    17
--- old/pwcheck/pwcheck_getpwnam.c	2015-04-07 17:03:52.497417754 -0700
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    18
+++ new/pwcheck/pwcheck_getpwnam.c	2013-07-11 07:56:26.000000000 -0700
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    19
@@ -32,6 +32,7 @@ char *userid;
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    20
 char *password;
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    21
 {
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    22
     char* r;
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    23
+    char* crpt_passwd;
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    24
     struct passwd *pwd;
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    25
 
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    26
     pwd = getpwnam(userid);
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    27
@@ -41,7 +42,7 @@ char *password;
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    28
     else if (pwd->pw_passwd[0] == '*') {
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    29
 	r = "Account disabled";
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    30
     }
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    31
-    else if (strcmp(pwd->pw_passwd, crypt(password, pwd->pw_passwd)) != 0) {
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    32
+    else if (!(crpt_passwd = crypt(password, pwd->pw_passwd)) || strcmp(pwd->pw_passwd, (const char *)crpt_passwd) != 0) {
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    33
 	r = "Incorrect password";
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    34
     }
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    35
     else {
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    36
diff -rupN old/pwcheck/pwcheck_getspnam.c new/pwcheck/pwcheck_getspnam.c
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    37
--- old/pwcheck/pwcheck_getspnam.c	2015-04-07 17:03:52.508074499 -0700
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    38
+++ new/pwcheck/pwcheck_getspnam.c	2013-07-11 07:56:26.000000000 -0700
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    39
@@ -32,13 +32,15 @@ char *userid;
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    40
 char *password;
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    41
 {
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    42
     struct spwd *pwd;
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    43
+    char *crpt_passwd;
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    44
 
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    45
     pwd = getspnam(userid);
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    46
     if (!pwd) {
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    47
 	return "Userid not found";
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    48
     }
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    49
     
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    50
-    if (strcmp(pwd->sp_pwdp, crypt(password, pwd->sp_pwdp)) != 0) {
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    51
+    crpt_passwd = crypt(password, pwd->sp_pwdp);
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    52
+    if (!crpt_passwd || strcmp(pwd->sp_pwdp, (const char *)crpt_passwd) != 0) {
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    53
 	return "Incorrect password";
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    54
     }
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    55
     else {
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    56
diff -rupN old/saslauthd/auth_getpwent.c new/saslauthd/auth_getpwent.c
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    57
--- old/saslauthd/auth_getpwent.c	2015-04-07 17:04:22.961304455 -0700
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    58
+++ new/saslauthd/auth_getpwent.c	2013-07-11 07:56:26.000000000 -0700
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    59
@@ -77,6 +77,7 @@ auth_getpwent (
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    60
 {
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    61
     /* VARIABLES */
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    62
     struct passwd *pw;			/* pointer to passwd file entry */
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    63
+    char *crpt_passwd;			/* encrypted password */
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    64
     int errnum;
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    65
     /* END VARIABLES */
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    66
   
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    67
@@ -105,7 +106,8 @@ auth_getpwent (
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    68
 	}
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    69
     }
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    70
 
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    71
-    if (strcmp(pw->pw_passwd, (const char *)crypt(password, pw->pw_passwd))) {
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    72
+    crpt_passwd = crypt(password, pw->pw_passwd);
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    73
+    if (!crpt_passwd || strcmp(pw->pw_passwd, (const char *)crpt_passwd)) {
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    74
 	if (flags & VERBOSE) {
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    75
 	    syslog(LOG_DEBUG, "DEBUG: auth_getpwent: %s: invalid password", login);
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    76
 	}
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    77
diff -rupN old/saslauthd/auth_shadow.c new/saslauthd/auth_shadow.c
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    78
--- old/saslauthd/auth_shadow.c	2015-04-07 17:04:22.968116900 -0700
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    79
+++ new/saslauthd/auth_shadow.c	2013-07-11 07:56:26.000000000 -0700
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    80
@@ -210,8 +210,8 @@ auth_shadow (
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    81
 	RETURN("NO Insufficient permission to access NIS authentication database (saslauthd)");
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    82
     }
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    83
 
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    84
-    cpw = strdup((const char *)crypt(password, sp->sp_pwdp));
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    85
-    if (strcmp(sp->sp_pwdp, cpw)) {
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    86
+    cpw = crypt(password, sp->sp_pwdp);
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    87
+    if (!cpw || strcmp(sp->sp_pwdp, (const char *)cpw)) {
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    88
 	if (flags & VERBOSE) {
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    89
 	    /*
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    90
 	     * This _should_ reveal the SHADOW_PW_LOCKED prefix to an
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    91
@@ -221,10 +221,8 @@ auth_shadow (
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    92
 	    syslog(LOG_DEBUG, "DEBUG: auth_shadow: pw mismatch: '%s' != '%s'",
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    93
 		   sp->sp_pwdp, cpw);
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    94
 	}
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    95
-	free(cpw);
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    96
 	RETURN("NO Incorrect password");
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    97
     }
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    98
-    free(cpw);
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
    99
 
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
   100
     /*
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
   101
      * The following fields will be set to -1 if:
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
   102
@@ -286,7 +284,7 @@ auth_shadow (
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
   103
 	RETURN("NO Invalid username");
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
   104
     }
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
   105
   
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
   106
-    if (strcmp(upw->upw_passwd, crypt(password, upw->upw_passwd)) != 0) {
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
   107
+    if (!(cpw = crypt(password, upw->upw_passwd)) || (strcmp(upw->upw_passwd, (const char *)cpw) != 0)) {
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
   108
 	if (flags & VERBOSE) {
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
   109
 	    syslog(LOG_DEBUG, "auth_shadow: pw mismatch: %s != %s",
9daf220c1a9a PSARC/2015/194 libsasl ON to Userland migration and update
Jan Parcel <jan.parcel@oracle.com>
parents:
diff changeset
   110
 		   password, upw->upw_passwd);