/*
 * CDDL HEADER START
 *
 * The contents of this file are subject to the terms of the
 * Common Development and Distribution License (the "License").
 * You may not use this file except in compliance with the License.
 *
 * You can obtain a copy of the license at usr/src/OPENSOLARIS.LICENSE
 * or http://www.opensolaris.org/os/licensing.
 * See the License for the specific language governing permissions
 * and limitations under the License.
 *
 * When distributing Covered Code, include this CDDL HEADER in each
 * file and include the License file at usr/src/OPENSOLARIS.LICENSE.
 * If applicable, add the following below this CDDL HEADER, with the
 * fields enclosed by brackets "[]" replaced with your own identifying
 * information: Portions Copyright [yyyy] [name of copyright owner]
 *
 * CDDL HEADER END
 */

/*
 * Copyright 2009 Sun Microsystems, Inc.  All rights reserved.
 * Use is subject to license terms.
 */

#include <sys/list.h>
#include <string.h>
#include <stdio.h>
#include <stdlib.h>
#include <stddef.h>
#include <unistd.h>

#include <libscf.h>
#include <libscf_priv.h>

#include "rad_adr.h"
#include "rad_object.h"
#include "rad_modapi.h"
#include "rad_util.h"
#include "rad_log.h"
#include "rad.h"

#include "api_smf.h"

extern int rad_read_propvec(const char *, const char *, boolean_t,
    scf_propvec_t *, scf_propvec_t **);

static pthread_mutex_t service_lock = PTHREAD_MUTEX_INITIALIZER;
static list_t service_list;
static list_t instance_list;
static instance_t *agg_inst;
static int service_count = 0;
static int instance_count = 0;

static const char *instance_pattern =
    "org.opensolaris.os.smf:type=service,service=%s,instance=%s";
static const char *service_pattern =
    "org.opensolaris.os.smf:type=service,service=%s";
static const char *aggregator_pattern =
    "org.opensolaris.os.smf:type=aggregator";

typedef struct servinst {
	char *sname;		/* Service name */
	char *iname;		/* Instance name */
	char *fmri;		/* FMRI */
	instance_t *inst;	/* rad object instance */
	boolean_t instance;

	int ninstances;
	list_t instances;	/* A service's instances */
	list_node_t node;	/* Membership in the global list */
	list_node_t snode;	/* An instance's membership in its service */
} servinst_t;

const char *framework_pgtypes[] = {
	SCF_GROUP_FRAMEWORK,
	SCF_GROUP_DEPENDENCY,
	SCF_GROUP_METHOD,
	SCF_GROUP_TEMPLATE,
	SCF_GROUP_TEMPLATE_PG_PATTERN,
	SCF_GROUP_TEMPLATE_PROP_PATTERN,
	NULL
};

static conerr_t
error_scf(data_t **error, int code)
{
	if (error != NULL) {
		data_t *e = data_new_struct(&t__SmfError);
		struct_set(e, "error", data_new_enum(&t__SmfErrorCode, code));
		struct_set(e, "message",
		    data_new_string(scf_strerror(code), lt_const));
		*error = data_purify(e);
	}
	return (ce_object);
}

static conerr_t
simple_scf(data_t **error, int result)
{
	if (result == 0)
		return (ce_ok);
	return (error_scf(error, scf_error()));
}

static boolean_t
strinset(const char **set, const char *str)
{
	for (; *set != NULL; set++)
		if (strcmp(*set, str) == 0)
			return (B_TRUE);
	return (B_FALSE);
}

static boolean_t
strnotinset(const char **set, const char *str)
{
	return (!strinset(set, str));
}

scf_handle_t *
handle_create(void)
{
	scf_handle_t *h = scf_handle_create(SCF_VERSION);
	if (h == NULL)
		return (NULL);

	if (scf_handle_bind(h) == -1) {
		scf_handle_destroy(h);
		return (NULL);
	}
	return (h);
}

static int getpgs(servinst_t *si, data_t **data, boolean_t namesonly,
    boolean_t(*fp)(const char **, const char *), const char **set,
    data_t **error)
{
	conerr_t err = ce_ok;
	scf_handle_t *scfhandle = handle_create();
	scf_service_t *service = scf_service_create(scfhandle);
	scf_instance_t *instance = scf_instance_create(scfhandle);
	scf_snapshot_t *snap = scf_snapshot_create(scfhandle);
	scf_iter_t *iter = scf_iter_create(scfhandle);
	scf_propertygroup_t *pg = scf_pg_create(scfhandle);

	if (scf_handle_decode_fmri(scfhandle, si->fmri, NULL, service,
	    instance, NULL, NULL, 0) != SCF_SUCCESS) {
		rad_log(RL_WARN, "Couldn't decode '%s': %s\n", si->fmri,
		    scf_strerror(scf_error()));
		err = error_scf(error, scf_error());
		goto out;
	}

	if (si->instance) {
		if (scf_instance_get_snapshot(instance, "running", snap) != 0 ||
		    scf_iter_instance_pgs_composed(iter, instance, snap)
		    != SCF_SUCCESS) {
			err = error_scf(error, scf_error());
			goto out;
		}
	} else {
		if (scf_iter_service_pgs(iter, service) != SCF_SUCCESS) {
			rad_log(RL_WARN, "failed to initialize iterator: %s\n",
			    scf_strerror(scf_error()));
			err = error_scf(error, scf_error());
			goto out;
		}
	}

	data_t *result = namesonly ? data_new_array(&t_array_string, 5) :
	    data_new_array(&t_array__PropertyGroup, 5);
	while (scf_iter_next_pg(iter, pg) > 0) {
		char nbuf[1000];
		char tbuf[1000];
		scf_pg_get_name(pg, nbuf, 1000);
		scf_pg_get_type(pg, tbuf, 1000);

		if (fp(set, tbuf)) {
			if (namesonly) {
				array_add(result,
				    data_new_string(nbuf, lt_copy));
			} else {
				data_t *pgdata =
				    data_new_struct(&t__PropertyGroup);
				struct_set(pgdata, "name",
				    data_new_string(nbuf, lt_copy));
				struct_set(pgdata, "type",
				    data_new_string(tbuf, lt_copy));
				array_add(result, pgdata);
			}
		}
	}

	*data = result;

out:
	scf_pg_destroy(pg);
	scf_snapshot_destroy(snap);
	scf_iter_destroy(iter);
	scf_instance_destroy(instance);
	scf_service_destroy(service);
	scf_handle_destroy(scfhandle);

	return (err);
}

/* ARGSUSED */
conerr_t
api_serviceInfo_read_MethodNames(struct instance *inst, struct attribute *attr,
    data_t **data, data_t **error)
{
	const char *pgtypes[] = { SCF_GROUP_METHOD, NULL };
	return (getpgs(inst->i_data, data, B_TRUE, strinset, pgtypes, error));
}

/* ARGSUSED */
conerr_t
api_serviceInfo_read_DependencyNames(struct instance *inst,
    struct attribute *attr, data_t **data, data_t **error)
{
	const char *pgtypes[] = { SCF_GROUP_DEPENDENCY, NULL };
	return (getpgs(inst->i_data, data, B_TRUE, strinset, pgtypes, error));
}

/* ARGSUSED */
conerr_t
api_serviceInfo_read_PropertyGroups(struct instance *inst,
    struct attribute *attr, data_t **data, data_t **error)
{
	return (getpgs(inst->i_data, data, B_FALSE, strnotinset,
	    framework_pgtypes, error));
}

/* ARGSUSED */
conerr_t
api_serviceInfo_read_Manpages(struct instance *inst, struct attribute *attr,
    data_t **data, data_t **error)
{
	servinst_t *si = inst->i_data;
	char *title, *section, *path;
	scf_propvec_t *badprop;
	scf_propvec_t evec[] = {
		{ SCF_PROPERTY_TM_MANPATH, NULL, SCF_TYPE_USTRING, &path, 0 },
		{ SCF_PROPERTY_TM_TITLE, NULL, SCF_TYPE_USTRING, &title, 0 },
		{ SCF_PROPERTY_TM_SECTION, NULL, SCF_TYPE_USTRING, &section,
		0 },
		{ NULL }
	};

	const char *pgtypes[] = {
		SCF_GROUP_TEMPLATE,
		NULL
	};

	data_t *pgs;
	conerr_t err = getpgs(si, &pgs, B_TRUE, strinset, pgtypes, error);
	if (err != ce_ok)
		return (err);
	data_t *result = data_new_array(&t_array__Manpage, 5);
	for (int i = 0; i < pgs->d_rsize; i++) {
		const char *str = pgs->d_data.array[i]->d_data.string;
		if (strncmp(str, SCF_PG_TM_MAN_PREFIX,
		    strlen(SCF_PG_TM_MAN_PREFIX)) != 0) {
			continue;
		}

		if (rad_read_propvec(si->fmri, str, B_FALSE, evec,
		    &badprop) != 0)
			continue;

		data_t *mp = data_new_struct(&t__Manpage);
		struct_set(mp, "title", data_new_string(title, lt_copy));
		struct_set(mp, "section", data_new_string(section, lt_copy));
		struct_set(mp, "path", data_new_string(path, lt_copy));
		array_add(result, mp);
		scf_clean_propvec(evec);
	}
	data_free(pgs);
	*data = result;

	return (ce_ok);
}

/* ARGSUSED */
conerr_t
api_serviceInfo_read_Doclinks(struct instance *inst, struct attribute *attr,
    data_t **data, data_t **error)
{
	servinst_t *si = inst->i_data;
	char *uri;
	scf_propvec_t *badprop;
	scf_propvec_t evec[] = {
		{ SCF_PROPERTY_TM_URI, NULL, SCF_TYPE_USTRING, &uri, 0 },
		{ NULL }
	};

	const char *pgtypes[] = {
		SCF_GROUP_TEMPLATE,
		NULL
	};

	data_t *pgs;
	conerr_t err = getpgs(si, &pgs, B_TRUE, strinset, pgtypes, error);
	if (err != ce_ok)
		return (err);
	data_t *result = data_new_array(&t_array_string, 5);
	for (int i = 0; i < pgs->d_rsize; i++) {
		const char *str = pgs->d_data.array[i]->d_data.string;
		if (strncmp(str, SCF_PG_TM_DOC_PREFIX,
		    strlen(SCF_PG_TM_DOC_PREFIX)) != 0) {
			continue;
		}

		if (rad_read_propvec(si->fmri, str, B_FALSE, evec,
		    &badprop) == 0) {
			array_add(result, data_new_string(uri, lt_copy));
			scf_clean_propvec(evec);
		}
	}
	data_free(pgs);
	*data = result;

	return (ce_ok);
}

/* ARGSUSED */
conerr_t
api_serviceInfo_read_PersistentlyEnabled(struct instance *inst,
    struct attribute *attr, data_t **data, data_t **error)
{
	servinst_t *si = inst->i_data;
	if (!si->instance)
		return (error_scf(error, SCF_ERROR_INVALID_ARGUMENT));

	boolean_t enabled;
	scf_propvec_t evec[] = {
		{ SCF_PROPERTY_ENABLED, NULL, SCF_TYPE_BOOLEAN, &enabled, 0 },
		{ NULL }
	};

	scf_propvec_t *badprop;
	int scferr = rad_read_propvec(si->fmri, SCF_PG_GENERAL, B_FALSE,
	    evec, &badprop);
	if (scferr != 0)
		return (error_scf(error, scferr));
	scf_clean_propvec(evec);

	*data = data_new_boolean(enabled);
	return (ce_ok);
}

/* ARGSUSED */
conerr_t
api_serviceInfo_read_TemporarilyEnabled(struct instance *inst,
    struct attribute *attr, data_t **data, data_t **error)
{
	servinst_t *si = inst->i_data;
	if (!si->instance)
		return (error_scf(error, SCF_ERROR_INVALID_ARGUMENT));

	boolean_t enabled;
	scf_propvec_t evec[] = {
		{ SCF_PROPERTY_ENABLED, NULL, SCF_TYPE_BOOLEAN, &enabled, 0 },
		{ NULL }
	};

	scf_propvec_t *badprop;
	if (rad_read_propvec(si->fmri, SCF_PG_GENERAL_OVR, B_FALSE, evec,
	    &badprop) != 0)
		return (api_serviceInfo_read_PersistentlyEnabled(inst, attr,
		    data, error));
	scf_clean_propvec(evec);

	*data = data_new_boolean(enabled);
	return (ce_ok);
}

/* ARGSUSED */
conerr_t
api_serviceInfo_read_Enabled(struct instance *inst, struct attribute *attr,
    data_t **data, data_t **error)
{
	/*
	 * XXX: The java version always had the same implementation for both.
	 */
	return (api_serviceInfo_read_PersistentlyEnabled(inst, attr, data,
	    error));
}

/* ARGSUSED */
conerr_t
api_serviceInfo_read_Instance(struct instance *inst, struct attribute *attr,
    data_t **data, data_t **error)
{
	servinst_t *si = inst->i_data;
	*data = data_new_boolean(si->instance);
	return (ce_ok);
}

/* ARGSUSED */
conerr_t
api_serviceInfo_read_Restarter(struct instance *inst, struct attribute *attr,
    data_t **data, data_t **error)
{
	servinst_t *si = inst->i_data;
	if (!si->instance)
		return (error_scf(error, SCF_ERROR_INVALID_ARGUMENT));

	char *fmri = NULL;
	scf_propvec_t evec[] = {
		{ SCF_PROPERTY_RESTARTER, NULL, SCF_TYPE_USTRING, &fmri, 0 },
		{ NULL }
	};

	scf_propvec_t *badprop;
	if (rad_read_propvec(si->fmri, SCF_PG_GENERAL, B_FALSE, evec,
	    &badprop) == 0) {
		*data = data_new_string(fmri, lt_copy);
		scf_clean_propvec(evec);
	} else {
		*data = data_new_fstring("svc:/%s:%s",
		    "system/svc/restarter", "default");
	}

	return (*data != NULL ? ce_ok : ce_system);
}

static data_t *
state2enum(const char *state)
{
	if (strcmp(state, SCF_STATE_STRING_UNINIT) == 0) {
		return (data_new_enum_byname(&t__SmfState, "UNINIT"));
	} else if (strcmp(state, SCF_STATE_STRING_MAINT) == 0) {
		return (data_new_enum_byname(&t__SmfState, "MAINT"));
	} else if (strcmp(state, SCF_STATE_STRING_LEGACY) == 0) {
		return (data_new_enum_byname(&t__SmfState, "LEGACY"));
	} else {
		return (data_new_enum_byname(&t__SmfState, state));
	}
}

/* ARGSUSED */
conerr_t
api_serviceInfo_read_State(struct instance *inst, struct attribute *attr,
    data_t **data, data_t **error)
{
	servinst_t *si = inst->i_data;
	if (!si->instance)
		return (error_scf(error, SCF_ERROR_INVALID_ARGUMENT));

	char *state = smf_get_state(si->fmri);
	if (state == NULL)
		return (error_scf(error, scf_error()));

	*data = state2enum(state);
	free(state);
	return (*data != NULL ? ce_ok : ce_system);
}

/* ARGSUSED */
conerr_t
api_serviceInfo_read_NextState(struct instance *inst, struct attribute *attr,
    data_t **data, data_t **error)
{
	servinst_t *si = inst->i_data;
	if (!si->instance)
		return (error_scf(error, SCF_ERROR_INVALID_ARGUMENT));

	char *state = NULL;
	scf_propvec_t evec[] = {
		{ SCF_PROPERTY_NEXT_STATE, NULL, SCF_TYPE_ASTRING, &state, 0 },
		{ NULL }
	};

	scf_propvec_t *badprop;
	int scferr = rad_read_propvec(si->fmri, SCF_PG_RESTARTER, B_FALSE, evec,
	    &badprop);
	if (scferr != 0)
		return (error_scf(error, scferr));

	*data = state2enum(state);
	scf_clean_propvec(evec);
	return (*data != NULL ? ce_ok : ce_system);
}

conerr_t
api_serviceInfo_read_AuxiliaryState(struct instance *inst,
    struct attribute *attr, data_t **data, data_t **error)
{
	servinst_t *si = inst->i_data;
	if (!si->instance)
		return (error_scf(error, SCF_ERROR_INVALID_ARGUMENT));

	char *aux;
	scf_propvec_t evec[] = {
		{ SCF_PROPERTY_AUX_STATE, NULL, SCF_TYPE_ASTRING, &aux, 0 },
		{ NULL }
	};

	scf_propvec_t *badprop;
	int scferr = rad_read_propvec(si->fmri, SCF_PG_RESTARTER, B_FALSE, evec,
	    &badprop);
	if (scferr != 0)
		return (error_scf(error, scferr));

	*data = data_new_string(aux, lt_copy);
	scf_clean_propvec(evec);

	return (*data != NULL ? ce_ok : ce_system);
}

/* ARGSUSED */
conerr_t
api_serviceInfo_read_STime(struct instance *inst, struct attribute *attr,
    data_t **data, data_t **error)
{
	servinst_t *si = inst->i_data;
	if (!si->instance)
		return (error_scf(error, SCF_ERROR_INVALID_ARGUMENT));

	scf_time_t time;
	scf_propvec_t evec[] = {
		{ SCF_PROPERTY_STATE_TIMESTAMP, NULL, SCF_TYPE_TIME, &time, 0 },
		{ NULL }
	};

	scf_propvec_t *badprop;
	int scferr = rad_read_propvec(si->fmri, SCF_PG_RESTARTER, B_FALSE, evec,
	    &badprop);
	if (scferr != 0)
		return (error_scf(error, scferr));

	scf_clean_propvec(evec);

	*data = data_new_time(time.t_seconds);

	return (*data != NULL ? ce_ok : ce_system);
}

/* ARGSUSED */
conerr_t
api_serviceInfo_read_ContractID(struct instance *inst, struct attribute *attr,
    data_t **data, data_t **error)
{
	servinst_t *si = inst->i_data;
	if (!si->instance)
		return (error_scf(error, SCF_ERROR_INVALID_ARGUMENT));

	uint64_t count;
	scf_propvec_t evec[] = {
		{ SCF_PROPERTY_CONTRACT, NULL, SCF_TYPE_COUNT, &count, 0 },
		{ NULL }
	};

	scf_propvec_t *badprop;
	int scferr = rad_read_propvec(si->fmri, SCF_PG_RESTARTER, B_FALSE, evec,
	    &badprop);
	if (scferr != 0)
		return (error_scf(error, scferr));
	scf_clean_propvec(evec);

	*data = data_new_long(count);

	return (*data != NULL ? ce_ok : ce_system);
}

/* ARGSUSED */
conerr_t
api_serviceInfo_read_Reason(struct instance *inst, struct attribute *attr,
    data_t **data, data_t **error)
{
	servinst_t *si = inst->i_data;
	if (!si->instance)
		return (error_scf(error, SCF_ERROR_INVALID_ARGUMENT));
	*data = NULL;
	return (ce_ok);
}

/* ARGSUSED */
conerr_t
api_serviceInfo_write_PersistentlyEnabled(struct instance *inst,
    struct attribute *attr, data_t *data, data_t **error)
{
	servinst_t *si = inst->i_data;
	boolean_t enable = data->d_data.boolean;
	if (!si->instance)
		return (error_scf(error, SCF_ERROR_INVALID_ARGUMENT));

	return (simple_scf(error, enable ? smf_enable_instance(si->fmri, 0) :
	    smf_disable_instance(si->fmri, 0)));
}

static conerr_t
get_pg(scf_handle_t *scfhandle, scf_propertygroup_t *pg, servinst_t *si,
    const char *snapname, const char *pgname, data_t **error)
{
	conerr_t err = ce_ok;
	scf_service_t *service = scf_service_create(scfhandle);
	scf_instance_t *instance = scf_instance_create(scfhandle);
	scf_snapshot_t *snap = scf_snapshot_create(scfhandle);

	if (service == NULL || instance == NULL || snap == NULL) {
		err = error_scf(error, SCF_ERROR_NO_MEMORY);
		goto out;
	}

	if (scf_handle_decode_fmri(scfhandle, si->fmri, NULL, service,
	    instance, NULL, NULL, 0) != SCF_SUCCESS) {
		rad_log(RL_WARN, "Couldn't decode '%s': %s\n",
		    si->fmri, scf_strerror(scf_error()));
		err = error_scf(error, scf_error());
		goto out;
	}

	if (si->instance) {
		scf_snapshot_t *usesnap = NULL;
		if (snapname != NULL) {
			usesnap = snap;
			if (scf_instance_get_snapshot(instance, snapname, snap)
			    != 0) {
				err = error_scf(error, scf_error());
				goto out;
			}
		}
		if (scf_instance_get_pg_composed(instance, usesnap, pgname, pg)
		    != 0) {
			err = error_scf(error, scf_error());
			goto out;
		}
	} else {
		if (scf_service_get_pg(service, pgname, pg) != SCF_SUCCESS) {
			err = error_scf(error, scf_error());
			goto out;
		}
	}
out:
	scf_snapshot_destroy(snap);
	scf_instance_destroy(instance);
	scf_service_destroy(service);
	return (err);
}

/* ARGSUSED */
conerr_t
api_serviceInfo_invoke_getDependency(struct instance *inst, struct method *meth,
    data_t **ret, data_t **args, int count, data_t **error)
{
	conerr_t err = ce_ok;
	const char *pgname = args[0]->d_data.string;
	servinst_t *si = inst->i_data;
	char type[1000];
	char grouping[1000];
	char restarton[1000];

	scf_handle_t *scfhandle = handle_create();
	scf_iter_t *iter = scf_iter_create(scfhandle);
	scf_propertygroup_t *pg = scf_pg_create(scfhandle);
	scf_property_t *prop = scf_property_create(scfhandle);
	scf_value_t *val = scf_value_create(scfhandle);

	if (scfhandle == NULL || iter == NULL || pg == NULL || prop == NULL ||
	    val == NULL) {
		err = error_scf(error, SCF_ERROR_NO_MEMORY);
		goto out;
	}
	if ((err = get_pg(scfhandle, pg, si, "running", pgname, error))
	    != ce_ok)
		goto out;

	if (scf_pg_get_type(pg, type, sizeof (type)) == 0) {
		err = error_scf(error, scf_error());
		goto out;
	}
	if (strcmp(type, SCF_GROUP_DEPENDENCY) != 0) {
		err = error_scf(error, SCF_ERROR_INVALID_ARGUMENT);
		goto out;
	}

	if (scf_pg_get_property(pg, SCF_PROPERTY_GROUPING, prop) != 0 ||
	    scf_property_get_value(prop, val) != 0 ||
	    scf_value_get_as_string(val, grouping, sizeof (grouping)) == -1 ||
	    scf_pg_get_property(pg, SCF_PROPERTY_RESTART_ON, prop) != 0 ||
	    scf_property_get_value(prop, val) != 0 ||
	    scf_value_get_as_string(val, restarton, sizeof (restarton)) == -1 ||
	    scf_pg_get_property(pg, SCF_PROPERTY_ENTITIES, prop) != 0 ||
	    scf_iter_property_values(iter, prop) != 0) {
		err = error_scf(error, scf_error());
		goto out;
	}

	data_t *result = data_new_struct(&t__Dependency);
	data_t *array = data_new_array(&t_array_string, 5);
	struct_set(result, "name", data_ref(args[0]));
	struct_set(result, "grouping", data_new_string(grouping, lt_copy));
	struct_set(result, "restartOn", data_new_string(restarton, lt_copy));
	struct_set(result, "target", array);
	while (scf_iter_next_value(iter, val) > 0) {
		if (scf_value_get_as_string(val, type, sizeof (type)) == -1) {
			err = error_scf(error, scf_error());
			data_free(result);
			goto out;
		}
		array_add(array, data_new_string(type, lt_copy));
	}
	if (!data_verify(result, NULL, B_TRUE)) {
		data_free(result);
		err = error_scf(error, SCF_ERROR_NO_MEMORY);
		goto out;
	}

	*ret = result;
out:
	scf_value_destroy(val);
	scf_property_destroy(prop);
	scf_pg_destroy(pg);
	scf_iter_destroy(iter);
	scf_handle_destroy(scfhandle);
	return (err);
}

/* ARGSUSED */
conerr_t
api_serviceInfo_invoke_getPropertyNames(struct instance *inst,
    struct method *meth, data_t **ret, data_t **args, int count, data_t **error)
{
	conerr_t err = ce_ok;
	const char *pgname = args[0]->d_data.string;
	servinst_t *si = inst->i_data;

	scf_handle_t *scfhandle = handle_create();
	scf_iter_t *iter = scf_iter_create(scfhandle);
	scf_propertygroup_t *pg = scf_pg_create(scfhandle);
	scf_property_t *prop = scf_property_create(scfhandle);

	if (scfhandle == NULL || iter == NULL || pg == NULL || prop == NULL) {
		err = error_scf(error, SCF_ERROR_NO_MEMORY);
		goto out;
	}

	if ((err = get_pg(scfhandle, pg, si, "running", pgname, error))
	    != ce_ok)
		goto out;

	data_t *result = data_new_array(&t_array_string, 5);
	scf_iter_pg_properties(iter, pg);
	while (scf_iter_next_property(iter, prop) > 0) {
		char pbuf[1000];
		scf_property_get_name(prop, pbuf, 1000);
		array_add(result, data_new_string(pbuf, lt_copy));
	}
	*ret = result;

out:
	scf_property_destroy(prop);
	scf_pg_destroy(pg);
	scf_iter_destroy(iter);
	scf_handle_destroy(scfhandle);

	return (err);
}

/* ARGSUSED */
conerr_t
api_serviceInfo_invoke_getPropertyType(struct instance *inst,
    struct method *meth, data_t **ret, data_t **args, int count, data_t **error)
{
	const char *pgname = args[0]->d_data.string;
	const char *propname = args[1]->d_data.string;
	conerr_t err = ce_ok;
	servinst_t *si = inst->i_data;

	scf_handle_t *scfhandle = handle_create();
	scf_propertygroup_t *pg = scf_pg_create(scfhandle);
	scf_property_t *prop = scf_property_create(scfhandle);
	scf_type_t type;

	if (scfhandle == NULL || pg == NULL || prop == NULL) {
		err = error_scf(error, SCF_ERROR_NO_MEMORY);
		goto out;
	}
	if ((err = get_pg(scfhandle, pg, si, "running", pgname, error))
	    != ce_ok)
		goto out;

	if (scf_pg_get_property(pg, propname, prop) != 0 ||
	    scf_property_type(prop, &type) != 0) {
		err = error_scf(error, scf_error());
		goto out;
	}

	data_t *result = data_new_enum(&t__PropertyType, type);
	if (result != NULL)
		*ret = result;
	else
		err = error_scf(error, SCF_ERROR_NO_MEMORY);

out:
	scf_property_destroy(prop);
	scf_pg_destroy(pg);
	scf_handle_destroy(scfhandle);
	return (err);
}

/* ARGSUSED */
conerr_t
api_serviceInfo_invoke_getPropertyValues(struct instance *inst,
    struct method *meth, data_t **ret, data_t **args, int count, data_t **error)
{
	conerr_t err = ce_ok;
	const char *pgname = args[0]->d_data.string;
	const char *propname = args[1]->d_data.string;

	servinst_t *si = inst->i_data;

	scf_handle_t *scfhandle = handle_create();
	scf_service_t *service = scf_service_create(scfhandle);
	scf_instance_t *instance = scf_instance_create(scfhandle);
	scf_snapshot_t *snap = scf_snapshot_create(scfhandle);
	scf_iter_t *iter = scf_iter_create(scfhandle);
	scf_propertygroup_t *pg = scf_pg_create(scfhandle);
	scf_property_t *prop = scf_property_create(scfhandle);
	scf_value_t *val = scf_value_create(scfhandle);

	if (scfhandle == NULL || service == NULL || instance == NULL ||
	    snap == NULL || iter == NULL || pg == NULL || prop == NULL ||
	    prop == NULL || val == NULL) {
		err = error_scf(error, SCF_ERROR_NO_MEMORY);
		goto out;
	}

	if (scf_handle_decode_fmri(scfhandle, si->fmri, NULL, service,
	    instance, NULL, NULL, 0) != SCF_SUCCESS) {
		rad_log(RL_WARN, "Couldn't decode '%s': %s\n",
		    si->fmri, scf_strerror(scf_error()));
		err = error_scf(error, scf_error());
		goto out;
	}
	if ((si->instance ? scf_instance_get_pg(instance, pgname, pg) :
	    scf_service_get_pg(service, pgname, pg)) != 0 ||
	    scf_pg_get_property(pg, propname, prop) != 0 ||
	    scf_iter_property_values(iter, prop) != 0) {
		err = error_scf(error, scf_error());
		goto out;
	}

	data_t *result = data_new_array(&t_array_string, 5);
	while (scf_iter_next_value(iter, val) > 0) {
		char pbuf[1000];
		scf_value_get_as_string(val, pbuf, 1000);
		array_add(result, data_new_string(pbuf, lt_copy));
	}
	*ret = result;
out:
	scf_value_destroy(val);
	scf_property_destroy(prop);
	scf_pg_destroy(pg);
	scf_iter_destroy(iter);
	scf_snapshot_destroy(snap);
	scf_instance_destroy(instance);
	scf_service_destroy(service);
	scf_handle_destroy(scfhandle);

	return (err);
}

/* ARGSUSED */
conerr_t
api_serviceInfo_invoke_getSnapshotPropertyValues(struct instance *inst,
    struct method *meth, data_t **ret, data_t **args, int count, data_t **error)
{
	conerr_t err = ce_ok;
	const char *snapname = args[0]->d_data.string;
	const char *pgname = args[1]->d_data.string;
	const char *propname = args[2]->d_data.string;

	servinst_t *si = inst->i_data;
	if (!si->instance)
		return (error_scf(error, SCF_ERROR_INVALID_ARGUMENT));

	rad_log(RL_DEBUG, "Reading from snapshot: %s\n", snapname);

	scf_handle_t *scfhandle = handle_create();
	scf_iter_t *iter = scf_iter_create(scfhandle);
	scf_propertygroup_t *pg = scf_pg_create(scfhandle);
	scf_property_t *prop = scf_property_create(scfhandle);
	scf_value_t *val = scf_value_create(scfhandle);

	if (scfhandle == NULL || iter == NULL || pg == NULL || prop == NULL ||
	    val == NULL) {
		err = error_scf(error, SCF_ERROR_NO_MEMORY);
		goto out;
	}

	if ((err = get_pg(scfhandle, pg, si, "running", pgname, error))
	    != ce_ok)
		goto out;
	if (scf_pg_get_property(pg, propname, prop) != 0) {
		err = error_scf(error, scf_error());
		goto out;
	}

	data_t *result = data_new_array(&t_array_string, 5);
	scf_iter_property_values(iter, prop);
	while (scf_iter_next_value(iter, val) > 0) {
		char pbuf[1000];
		scf_value_get_as_string(val, pbuf, 1000);
		array_add(result, data_new_string(pbuf, lt_copy));
	}
	*ret = result;
out:
	scf_value_destroy(val);
	scf_property_destroy(prop);
	scf_pg_destroy(pg);
	scf_iter_destroy(iter);
	scf_handle_destroy(scfhandle);

	return (err);
}

/* ARGSUSED */
conerr_t
api_serviceInfo_invoke_setPropertyValues(struct instance *inst,
    struct method *meth, data_t **ret, data_t **args, int count, data_t **error)
{
	conerr_t err = ce_ok;
	const char *pgname = args[0]->d_data.string;
	const char *propname = args[1]->d_data.string;
	data_t *values = args[2];

	servinst_t *si = inst->i_data;

	scf_handle_t *scfhandle = handle_create();
	scf_service_t *service = scf_service_create(scfhandle);
	scf_instance_t *instance = scf_instance_create(scfhandle);
	scf_propertygroup_t *pg = scf_pg_create(scfhandle);
	scf_property_t *prop = scf_property_create(scfhandle);
	scf_transaction_t *tx = scf_transaction_create(scfhandle);
	scf_transaction_entry_t *ent = scf_entry_create(scfhandle);
	scf_value_t **val = zalloc(values->d_rsize * sizeof (scf_value_t *));
	scf_type_t type;

	if (scfhandle == NULL || service == NULL || instance == NULL ||
	    pg == NULL || prop == NULL || tx == NULL || ent == NULL ||
	    val == NULL) {
		err = error_scf(error, SCF_ERROR_NO_MEMORY);
		goto out;
	}

	for (int i = 0; i < values->d_rsize; i++) {
		if ((val[i] = scf_value_create(scfhandle)) == NULL) {
			err = error_scf(error, SCF_ERROR_NO_MEMORY);
			goto out;
		}
	}

	if (scf_handle_decode_fmri(scfhandle, si->fmri, NULL, service,
	    instance, NULL, NULL, 0) != SCF_SUCCESS) {
		rad_log(RL_WARN, "Couldn't decode '%s': %s\n",
		    si->fmri, scf_strerror(scf_error()));
		err = error_scf(error, scf_error());
		goto out;
	}

	if (si->instance) {
		/* XXX: silly logic from original java */
		if (scf_instance_get_pg(instance, pgname, pg) != 0 &&
		    scf_service_get_pg(service, pgname, pg) != 0) {
			err = error_scf(error, scf_error());
			goto out;
		}
	} else {
		if (scf_service_get_pg(service, pgname, pg) != 0) {
			err = error_scf(error, scf_error());
			goto out;
		}
	}

	if (scf_pg_get_property(pg, propname, prop) != 0 ||
	    scf_property_type(prop, &type) != 0) {
		err = error_scf(error, scf_error());
		goto out;
	}

top:
	if (scf_transaction_start(tx, pg) == -1) {
		err = error_scf(error, scf_error());
		goto out;
	}
	if (scf_transaction_property_change(tx, ent, propname, type) != 0) {
		err = error_scf(error, scf_error());
		goto out;
	}

	for (int i = 0; i < values->d_rsize; i++) {
		if (scf_value_set_from_string(val[i], type,
		    values->d_data.array[i]->d_data.string) != 0 ||
		    scf_entry_add_value(ent, val[i]) != 0) {
			err = error_scf(error, scf_error());
			goto out;
		}
	}

	int txret = scf_transaction_commit(tx);
	if (txret == 1)
		goto out;
	if (txret == 0 && scf_pg_update(pg) != -1) {
		scf_transaction_reset(tx);
		goto top;
	}
	err = error_scf(error, scf_error());

out:
	if (val != NULL) {
		for (int i = 0; i < values->d_rsize; i++) {
			if (val[i] == NULL)
				break;
			scf_value_destroy(val[i]);
		}
		free(val);
	}

	scf_entry_destroy(ent);
	scf_transaction_destroy(tx);
	scf_property_destroy(prop);
	scf_pg_destroy(pg);
	scf_instance_destroy(instance);
	scf_service_destroy(service);
	scf_handle_destroy(scfhandle);

	return (err);
}

/* ARGSUSED */
conerr_t
api_serviceInfo_invoke_createPropertyGroup(struct instance *inst,
    struct method *meth, data_t **ret, data_t **args, int count, data_t **error)
{
	conerr_t err = ce_ok;
	const char *pgname = args[0]->d_data.string;
	const char *pgtype = args[1]->d_data.string;

	servinst_t *si = inst->i_data;

	scf_handle_t *scfhandle = handle_create();
	scf_service_t *service = scf_service_create(scfhandle);
	scf_instance_t *instance = scf_instance_create(scfhandle);
	scf_propertygroup_t *pg = scf_pg_create(scfhandle);

	if (scfhandle == NULL || service == NULL || instance == NULL ||
	    pg == NULL) {
		err = error_scf(error, SCF_ERROR_NO_MEMORY);
		goto out;
	}

	if (scf_handle_decode_fmri(scfhandle, si->fmri, NULL, service,
	    instance, NULL, NULL, 0) != SCF_SUCCESS) {
		rad_log(RL_WARN, "Couldn't decode '%s': %s\n",
		    si->fmri, scf_strerror(scf_error()));
		err = error_scf(error, scf_error());
		goto out;
	}

	if (si->instance) {
		if (scf_instance_add_pg(instance, pgname, pgtype, 0, pg) != 0) {
			err = error_scf(error, scf_error());
			goto out;
		}
	} else {
		if (scf_service_add_pg(service, pgname, pgtype, 0, pg) != 0) {
			err = error_scf(error, scf_error());
			goto out;
		}
	}

out:
	scf_pg_destroy(pg);
	scf_instance_destroy(instance);
	scf_service_destroy(service);
	scf_handle_destroy(scfhandle);

	return (err);
}

/* ARGSUSED */
conerr_t
api_serviceInfo_invoke_deletePropertyGroup(struct instance *inst,
    struct method *meth, data_t **ret, data_t **args, int count, data_t **error)
{
	conerr_t err = ce_ok;
	const char *pgname = args[0]->d_data.string;

	servinst_t *si = inst->i_data;

	scf_handle_t *scfhandle = handle_create();
	scf_service_t *service = scf_service_create(scfhandle);
	scf_instance_t *instance = scf_instance_create(scfhandle);
	scf_propertygroup_t *pg = scf_pg_create(scfhandle);

	if (scfhandle == NULL || service == NULL || instance == NULL ||
	    pg == NULL) {
		err = error_scf(error, SCF_ERROR_NO_MEMORY);
		goto out;
	}

	if (scf_handle_decode_fmri(scfhandle, si->fmri, NULL, service,
	    instance, NULL, NULL, 0) != SCF_SUCCESS) {
		rad_log(RL_WARN, "Couldn't decode '%s': %s\n",
		    si->fmri, scf_strerror(scf_error()));
		err = error_scf(error, scf_error());
		goto out;
	}

	if (si->instance) {
		/* XXX: silly logic from original java */
		if (scf_instance_get_pg(instance, pgname, pg) != 0 &&
		    scf_service_get_pg(service, pgname, pg) != 0) {
			err = error_scf(error, scf_error());
			goto out;
		}
	} else {
		if (scf_service_get_pg(service, pgname, pg) != 0) {
			err = error_scf(error, scf_error());
			goto out;
		}
	}

	if (scf_pg_delete(pg) != 0) {
		err = error_scf(error, scf_error());
		goto out;
	}
out:
	scf_pg_destroy(pg);
	scf_instance_destroy(instance);
	scf_service_destroy(service);
	scf_handle_destroy(scfhandle);

	return (err);
}

/* ARGSUSED */
conerr_t
api_serviceInfo_invoke_createProperty(struct instance *inst,
    struct method *meth, data_t **ret, data_t **args, int count, data_t **error)
{
	conerr_t err = ce_ok;
	const char *pgname = args[0]->d_data.string;
	const char *propname = args[1]->d_data.string;
	scf_type_t type = enum_tovalue(args[2]);
	int sret;

	servinst_t *si = inst->i_data;

	scf_handle_t *scfhandle = handle_create();
	scf_service_t *service = scf_service_create(scfhandle);
	scf_instance_t *instance = scf_instance_create(scfhandle);
	scf_propertygroup_t *pg = scf_pg_create(scfhandle);
	scf_transaction_t *tx = scf_transaction_create(scfhandle);
	scf_transaction_entry_t *ent = scf_entry_create(scfhandle);

	if (scfhandle == NULL || service == NULL || instance == NULL ||
	    pg == NULL || tx == NULL || ent == NULL) {
		err = error_scf(error, SCF_ERROR_NO_MEMORY);
		goto out;
	}

	if (scf_handle_decode_fmri(scfhandle, si->fmri, NULL, service,
	    instance, NULL, NULL, 0) != SCF_SUCCESS) {
		rad_log(RL_WARN, "Couldn't decode '%s': %s\n",
		    si->fmri, scf_strerror(scf_error()));
		err = error_scf(error, scf_error());
		goto out;
	}

	if (si->instance) {
		/* XXX: silly logic from original java */
		if (scf_instance_get_pg(instance, pgname, pg) != 0 &&
		    scf_service_get_pg(service, pgname, pg) != 0) {
			err = error_scf(error, scf_error());
			goto out;
		}
	} else {
		if (scf_service_get_pg(service, pgname, pg) != 0) {
			err = error_scf(error, scf_error());
			goto out;
		}
	}

top:
	if (scf_transaction_start(tx, pg) == -1) {
		err = error_scf(error, scf_error());
		goto out;
	}
	sret = scf_transaction_property_change(tx, ent, propname, type);
	if (sret == -1 && scf_error() == SCF_ERROR_NOT_FOUND)
		sret = scf_transaction_property_new(tx, ent, propname, type);
	if (sret == -1) {
		err = error_scf(error, scf_error());
		goto out;
	}

	sret = scf_transaction_commit(tx);
	if (sret == 1)
		goto out;
	if (sret == 0 && scf_pg_update(pg) != -1) {
		scf_transaction_reset(tx);
		goto top;
	}
	err = error_scf(error, scf_error());

out:
	scf_entry_destroy(ent);
	scf_transaction_destroy(tx);
	scf_pg_destroy(pg);
	scf_instance_destroy(instance);
	scf_service_destroy(service);
	scf_handle_destroy(scfhandle);

	return (err);
}

/* ARGSUSED */
conerr_t
api_serviceInfo_invoke_deleteProperty(struct instance *inst,
    struct method *meth, data_t **ret, data_t **args, int count, data_t **error)
{
	conerr_t err = ce_ok;
	const char *pgname = args[0]->d_data.string;
	const char *propname = args[1]->d_data.string;
	int sret;

	servinst_t *si = inst->i_data;

	scf_handle_t *scfhandle = handle_create();
	scf_service_t *service = scf_service_create(scfhandle);
	scf_instance_t *instance = scf_instance_create(scfhandle);
	scf_propertygroup_t *pg = scf_pg_create(scfhandle);
	scf_transaction_t *tx = scf_transaction_create(scfhandle);
	scf_transaction_entry_t *ent = scf_entry_create(scfhandle);

	if (scfhandle == NULL || service == NULL || instance == NULL ||
	    pg == NULL || tx == NULL || ent == NULL) {
		err = error_scf(error, SCF_ERROR_NO_MEMORY);
		goto out;
	}

	if (scf_handle_decode_fmri(scfhandle, si->fmri, NULL, service,
	    instance, NULL, NULL, 0) != SCF_SUCCESS) {
		rad_log(RL_WARN, "Couldn't decode '%s': %s\n",
		    si->fmri, scf_strerror(scf_error()));
		err = error_scf(error, scf_error());
		goto out;
	}

	if (si->instance) {
		/* XXX: really, really silly logic from original java */
		if (scf_instance_get_pg(instance, pgname, pg) != 0 &&
		    scf_service_get_pg(service, pgname, pg) != 0) {
			err = error_scf(error, scf_error());
			goto out;
		}
	} else {
		if (scf_service_get_pg(service, pgname, pg) != 0) {
			err = error_scf(error, scf_error());
			goto out;
		}
	}

top:
	if (scf_transaction_start(tx, pg) == -1) {
		err = error_scf(error, scf_error());
		goto out;
	}
	if (scf_transaction_property_delete(tx, ent, propname) != 0) {
		err = error_scf(error, scf_error());
		goto out;
	}

	sret = scf_transaction_commit(tx);
	if (sret == 1)
		goto out;
	if (sret == 0 && scf_pg_update(pg) != -1) {
		scf_transaction_reset(tx);
		goto top;
	}
	err = error_scf(error, scf_error());

out:
	scf_entry_destroy(ent);
	scf_transaction_destroy(tx);
	scf_pg_destroy(pg);
	scf_instance_destroy(instance);
	scf_service_destroy(service);
	scf_handle_destroy(scfhandle);

	return (err);
}

/* ARGSUSED */
conerr_t
api_serviceInfo_invoke_getPropertyTemplate(struct instance *inst,
    struct method *meth, data_t **ret, data_t **args, int count, data_t **error)
{
	return (error_scf(error, SCF_ERROR_NOT_FOUND));
}

static int
get_localedprop(servinst_t *si, const char *locale, const char *name,
    data_t **ret, data_t **error)
{
	char *str;
	scf_propvec_t *badprop;
	scf_propvec_t evec[] = {
		{ locale, NULL, SCF_TYPE_ASTRING, &str, 0 },
		{ NULL }
	};

	int scferr = rad_read_propvec(si->fmri, name, B_TRUE, evec, &badprop);
	if (scferr != 0)
		return (error_scf(error, scferr));

	*ret = data_new_string(str, lt_copy);
	scf_clean_propvec(evec);
	return (ce_ok);
}

/* ARGSUSED */
conerr_t
api_serviceInfo_invoke_getCommonName(struct instance *inst, struct method *meth,
    data_t **ret, data_t **args, int count, data_t **error)
{
	const char *locale = args[0]->d_data.string;
	servinst_t *si = inst->i_data;

	if (get_localedprop(si, locale, SCF_PG_TM_COMMON_NAME, ret, NULL)
	    == ce_ok)
		return (ce_ok);
	return (get_localedprop(si, "C", SCF_PG_TM_COMMON_NAME, ret, error));
}

/* ARGSUSED */
conerr_t
api_serviceInfo_invoke_getDescription(struct instance *inst,
    struct method *meth, data_t **ret, data_t **args, int count, data_t **error)
{
	const char *locale = args[0]->d_data.string;
	servinst_t *si = inst->i_data;

	if (get_localedprop(si, locale, SCF_PG_TM_DESCRIPTION, ret, NULL)
	    == ce_ok)
		return (ce_ok);
	return (get_localedprop(si, "C", SCF_PG_TM_DESCRIPTION, ret, error));
}

/* ARGSUSED */
conerr_t
api_serviceInfo_invoke_clear(struct instance *inst, struct method *meth,
    data_t **ret, data_t **args, int count, data_t **error)
{
	servinst_t *si = inst->i_data;
	if (!si->instance)
		return (error_scf(error, SCF_ERROR_INVALID_ARGUMENT));

	return (simple_scf(error, smf_restore_instance(si->fmri)));
}

/* ARGSUSED */
conerr_t
api_serviceInfo_invoke_degrade(struct instance *inst, struct method *meth,
    data_t **ret, data_t **args, int count, data_t **error)
{
	servinst_t *si = inst->i_data;
	if (!si->instance)
		return (error_scf(error, SCF_ERROR_INVALID_ARGUMENT));

	return (simple_scf(error, smf_degrade_instance(si->fmri,
	    args[0]->d_data.boolean ? SMF_IMMEDIATE : 0)));
}

/* ARGSUSED */
conerr_t
api_serviceInfo_invoke_maintain(struct instance *inst, struct method *meth,
    data_t **ret, data_t **args, int count, data_t **error)
{
	servinst_t *si = inst->i_data;
	if (!si->instance)
		return (error_scf(error, SCF_ERROR_INVALID_ARGUMENT));

	return (simple_scf(error, smf_maintain_instance(si->fmri,
	    args[0]->d_data.boolean ? SMF_IMMEDIATE : 0)));
}

/* ARGSUSED */
conerr_t
api_serviceInfo_invoke_restart(struct instance *inst, struct method *meth,
    data_t **ret, data_t **args, int count, data_t **error)
{
	servinst_t *si = inst->i_data;
	if (!si->instance)
		return (error_scf(error, SCF_ERROR_INVALID_ARGUMENT));

	return (simple_scf(error, smf_restart_instance(si->fmri)));
}

/* ARGSUSED */
conerr_t
api_serviceInfo_invoke_refresh(struct instance *inst, struct method *meth,
    data_t **ret, data_t **args, int count, data_t **error)
{
	servinst_t *si = inst->i_data;
	if (!si->instance)
		return (error_scf(error, SCF_ERROR_INVALID_ARGUMENT));

	return (simple_scf(error, smf_refresh_instance(si->fmri)));
}

/* ARGSUSED */
conerr_t
api_aggregator_read_Services(struct instance *inst, struct attribute *attr,
    data_t **data, data_t **error)
{
	rad_mutex_enter(&service_lock);
	data_t *result = data_new_array(&t_array__Service, service_count);

	for (servinst_t *si = list_head(&service_list); si != NULL;
	    si = list_next(&service_list, si)) {
		data_t *insts = data_new_array(&t_array_string, si->ninstances);
		for (servinst_t *i = list_head(&si->instances); i != NULL;
		    i = list_next(&si->instances, i))
			array_add(insts, data_new_string(i->iname, lt_copy));

		data_t *service = data_new_struct(&t__Service);
		struct_set(service, "fmri", data_new_string(si->fmri, lt_copy));
		struct_set(service, "objectName", data_new_object(si->inst));
		struct_set(service, "instances", insts);
		array_add(result, service);
	}

	if (data_verify(result, NULL, B_TRUE))
		*data = result;
	else
		data_free(result);

	rad_mutex_exit(&service_lock);
	return (*data != NULL ? ce_ok : ce_object);
}

/* ARGSUSED */
conerr_t
api_aggregator_read_Instances(struct instance *inst, struct attribute *attr,
    data_t **data, data_t **error)
{
	rad_mutex_enter(&service_lock);
	data_t *result = data_new_array(&t_array__Instance, instance_count);

	for (servinst_t *si = list_head(&instance_list); si != NULL;
	    si = list_next(&instance_list, si)) {

		data_t *inst = data_new_struct(&t__Instance);
		struct_set(inst, "fmri", data_new_string(si->fmri, lt_copy));
		struct_set(inst, "objectName", data_new_object(si->inst));
		data_t *stime = NULL, *state = NULL;
		api_serviceInfo_read_STime(si->inst, NULL, &stime, NULL);
		api_serviceInfo_read_State(si->inst, NULL, &state, NULL);
		struct_set(inst, "STime", stime);
		struct_set(inst, "state", state);
		array_add(result, inst);
	}

	if (data_verify(result, NULL, B_TRUE))
		*data = result;
	else
		data_free(result);

	rad_mutex_exit(&service_lock);
	return (*data != NULL ? ce_ok : ce_object);
}

static rad_moderr_t
notify_thread(rad_thread_t *arg)
{
	scf_handle_t *scfhandle = handle_create();
	scf_service_t *service = scf_service_create(scfhandle);
	scf_instance_t *instance = scf_instance_create(scfhandle);
	scf_propertygroup_t *pg = scf_pg_create(scfhandle);
	char fmri[5];
	char sname[1000], iname[1000];
	servinst_t *si;
	int ret;

	if (scfhandle == NULL || service == NULL || instance == NULL ||
	    pg == NULL ||
	    _scf_notify_add_pgtype(scfhandle, SCF_GROUP_FRAMEWORK) != 0)
		goto out;

	rad_thread_ack(arg, rm_ok);
	while ((ret = _scf_notify_wait(pg, fmri, 5)) >= 0) {
		rad_log(RL_DEBUG, "received SMF event");

		if (ret > 0)
			continue;	/* We should care */

		if (scf_pg_get_parent_instance(pg, instance) != 0 ||
		    scf_instance_get_parent(instance, service) != 0 ||
		    scf_instance_get_name(instance, iname, 1000) == -1 ||
		    scf_service_get_name(service, sname, 1000) == -1)
			continue;

		rad_mutex_enter(&service_lock);

		for (si = list_head(&instance_list); si != NULL;
		    si = list_next(&instance_list, si))
			if (strcmp(si->iname, iname) == 0 &&
			    strcmp(si->sname, sname) == 0)
				break;

		if (si == NULL)
			continue;

		rad_log(RL_DEBUG, "identified SMF event: %s/%s", sname, iname);

		data_t *stime = NULL, *state = NULL, *nstate = NULL;
		data_t *astate = NULL, *reason = NULL;

		/* Inefficient, but expedient */
		api_serviceInfo_read_STime(si->inst, NULL, &stime, NULL);
		api_serviceInfo_read_State(si->inst, NULL, &state, NULL);
		api_serviceInfo_read_NextState(si->inst, NULL, &nstate, NULL);
		api_serviceInfo_read_AuxiliaryState(si->inst, NULL, &astate,
		    NULL);
		api_serviceInfo_read_Reason(si->inst, NULL, &reason, NULL);

		data_t *event = data_new_struct(&t__StateChange);
		struct_set(event, "source", data_new_object(si->inst));
		struct_set(event, "state", state);
		struct_set(event, "nextState", nstate);
		struct_set(event, "stateTime", stime);
		struct_set(event, "auxState", astate);
		struct_set(event, "reason", reason);
		struct_set(event, "anomaly", data_new_boolean(B_FALSE));
		if (data_verify(event, NULL, B_FALSE)) {
			rad_log(RL_DEBUG, "sending SMF event");
			if (agg_inst != NULL)
				inst_interest_notify(agg_inst, "statechange",
				    0, data_ref(event));
			inst_interest_notify(si->inst, "statechange", 0, event);
		} else {
			rad_log(RL_DEBUG, "failed to send SMF event");
			data_free(event);
		}

		rad_mutex_exit(&service_lock);
	}
	rad_log(RL_ERROR, "_scf_notify_wait failed: %s",
	    scf_strerror(scf_error()));

	/* XXX: reestablish on configd death */
out:
	scf_pg_destroy(pg);
	scf_instance_destroy(instance);
	scf_service_destroy(service);
	scf_handle_destroy(scfhandle);

	rad_log(RL_ERROR, "exiting SMF event loop");

	return (rm_system);
}

static servinst_t *
make_service(char *sname, char *iname)
{
	char *objname;
	boolean_t inst = iname != NULL;
	servinst_t *si = zalloc(sizeof (servinst_t));
	si->sname = strdup(sname);
	si->iname = inst ? strdup(iname) : NULL;
	if (si->instance = inst) {
		asprintf(&si->fmri, "svc:/%s:%s", sname, iname);
		asprintf(&objname, instance_pattern, sname, iname);
	} else {
		list_create(&si->instances, sizeof (servinst_t),
		    offsetof(servinst_t, snode));
		asprintf(&si->fmri, "svc:/%s", sname);
		asprintf(&objname, service_pattern, sname);
	}
	si->inst = instance_create(objname, &api_serviceInfo, si);
	(void) cont_insert(&rad_container, si->inst, NULL);

	if (inst) {
		list_insert_tail(&instance_list, si);
		instance_count++;
	} else {
		list_insert_tail(&service_list, si);
		service_count++;
	}


	return (si);
}

static rad_modinfo_t modinfo = { "smf", "SMF module" };

int
_rad_init(void *handle)
{
	if (rad_module_register(handle, RAD_MODVERSION, &modinfo) == -1)
		return (-1);

	if (rad_isproxy)
		return (0);

	list_create(&service_list, sizeof (servinst_t),
	    offsetof(servinst_t, node));
	list_create(&instance_list, sizeof (servinst_t),
	    offsetof(servinst_t, node));

	scf_handle_t *scfhandle = handle_create();
	scf_scope_t *scope = scf_scope_create(scfhandle);
	scf_iter_t *siter = scf_iter_create(scfhandle);
	scf_iter_t *iiter = scf_iter_create(scfhandle);
	scf_service_t *service = scf_service_create(scfhandle);
	scf_instance_t *instance = scf_instance_create(scfhandle);

	scf_handle_get_scope(scfhandle, SCF_SCOPE_LOCAL, scope);
	scf_iter_scope_services(siter, scope);
	while (scf_iter_next_service(siter, service) > 0) {
		char svcname[1000];
		scf_service_get_name(service, svcname, 1000);
		servinst_t *svc = make_service(svcname, NULL);
		scf_iter_service_instances(iiter, service);
		while (scf_iter_next_instance(iiter, instance) > 0) {
			char instname[1000];
			scf_instance_get_name(instance, instname, 1000);
			list_insert_tail(&svc->instances,
			    make_service(svcname, instname));
			svc->ninstances++;
		}
	}

	scf_instance_destroy(instance);
	scf_service_destroy(service);
	scf_iter_destroy(iiter);
	scf_iter_destroy(siter);
	scf_scope_destroy(scope);
	scf_handle_destroy(scfhandle);

	agg_inst = cont_insert_singleton(&rad_container, aggregator_pattern,
	    &api_aggregator, NULL);

	if (rad_thread_create(notify_thread, NULL) != rm_ok)
		rad_log(RL_ERROR, "failed to start SMF listener");
	return (0);
}