components/ruby/ruby-21/patches/08-CVE-2015-3900-4020.patch
author April Chin <april.chin@oracle.com>
Tue, 07 Jul 2015 16:42:20 -0700
changeset 4604 eba741d252dc
permissions -rw-r--r--
21330713 problem in UTILITY/RUBY
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
4604
eba741d252dc 21330713 problem in UTILITY/RUBY
April Chin <april.chin@oracle.com>
parents:
diff changeset
     1
Patches to RubyGems from upstream
eba741d252dc 21330713 problem in UTILITY/RUBY
April Chin <april.chin@oracle.com>
parents:
diff changeset
     2
to fix CVE-2015-3900:
eba741d252dc 21330713 problem in UTILITY/RUBY
April Chin <april.chin@oracle.com>
parents:
diff changeset
     3
https://github.com/rubygems/rubygems/commit/6bbee35fd6daed045103f3122490a588d97c066a
eba741d252dc 21330713 problem in UTILITY/RUBY
April Chin <april.chin@oracle.com>
parents:
diff changeset
     4
and CVE-2015-4020:
eba741d252dc 21330713 problem in UTILITY/RUBY
April Chin <april.chin@oracle.com>
parents:
diff changeset
     5
https://github.com/rubygems/rubygems/commit/5c7bfb5c05202b4db971dd672d88a42298a0d84e
eba741d252dc 21330713 problem in UTILITY/RUBY
April Chin <april.chin@oracle.com>
parents:
diff changeset
     6
eba741d252dc 21330713 problem in UTILITY/RUBY
April Chin <april.chin@oracle.com>
parents:
diff changeset
     7
--- ruby-2.1.6-orig/lib/rubygems/remote_fetcher.rb	2014-02-05 18:59:36.000000000 -0800
eba741d252dc 21330713 problem in UTILITY/RUBY
April Chin <april.chin@oracle.com>
parents:
diff changeset
     8
+++ ruby-2.1.6/lib/rubygems/remote_fetcher.rb	2015-07-06 14:51:51.198154766 -0700
eba741d252dc 21330713 problem in UTILITY/RUBY
April Chin <april.chin@oracle.com>
parents:
diff changeset
     9
@@ -90,7 +90,13 @@ class Gem::RemoteFetcher
eba741d252dc 21330713 problem in UTILITY/RUBY
April Chin <april.chin@oracle.com>
parents:
diff changeset
    10
     rescue Resolv::ResolvError
eba741d252dc 21330713 problem in UTILITY/RUBY
April Chin <april.chin@oracle.com>
parents:
diff changeset
    11
       uri
eba741d252dc 21330713 problem in UTILITY/RUBY
April Chin <april.chin@oracle.com>
parents:
diff changeset
    12
     else
eba741d252dc 21330713 problem in UTILITY/RUBY
April Chin <april.chin@oracle.com>
parents:
diff changeset
    13
-      URI.parse "#{uri.scheme}://#{res.target}#{uri.path}"
eba741d252dc 21330713 problem in UTILITY/RUBY
April Chin <april.chin@oracle.com>
parents:
diff changeset
    14
+      target = res.target.to_s.strip
eba741d252dc 21330713 problem in UTILITY/RUBY
April Chin <april.chin@oracle.com>
parents:
diff changeset
    15
+
eba741d252dc 21330713 problem in UTILITY/RUBY
April Chin <april.chin@oracle.com>
parents:
diff changeset
    16
+      if /\.#{Regexp.quote(host)}\z/ =~ target
eba741d252dc 21330713 problem in UTILITY/RUBY
April Chin <april.chin@oracle.com>
parents:
diff changeset
    17
+        return URI.parse "#{uri.scheme}://#{target}#{uri.path}"
eba741d252dc 21330713 problem in UTILITY/RUBY
April Chin <april.chin@oracle.com>
parents:
diff changeset
    18
+      end
eba741d252dc 21330713 problem in UTILITY/RUBY
April Chin <april.chin@oracle.com>
parents:
diff changeset
    19
+
eba741d252dc 21330713 problem in UTILITY/RUBY
April Chin <april.chin@oracle.com>
parents:
diff changeset
    20
+      uri
eba741d252dc 21330713 problem in UTILITY/RUBY
April Chin <april.chin@oracle.com>
parents:
diff changeset
    21
     end
eba741d252dc 21330713 problem in UTILITY/RUBY
April Chin <april.chin@oracle.com>
parents:
diff changeset
    22
   end
eba741d252dc 21330713 problem in UTILITY/RUBY
April Chin <april.chin@oracle.com>
parents:
diff changeset
    23
 
eba741d252dc 21330713 problem in UTILITY/RUBY
April Chin <april.chin@oracle.com>
parents:
diff changeset
    24
--- ruby-2.1.6-orig/test/rubygems/test_gem_remote_fetcher.rb	2014-02-05 18:59:36.000000000 -0800
eba741d252dc 21330713 problem in UTILITY/RUBY
April Chin <april.chin@oracle.com>
parents:
diff changeset
    25
+++ ruby-2.1.6/test/rubygems/test_gem_remote_fetcher.rb	2015-07-06 14:56:09.027603528 -0700
eba741d252dc 21330713 problem in UTILITY/RUBY
April Chin <april.chin@oracle.com>
parents:
diff changeset
    26
@@ -163,6 +163,21 @@ gems:
eba741d252dc 21330713 problem in UTILITY/RUBY
April Chin <april.chin@oracle.com>
parents:
diff changeset
    27
   end
eba741d252dc 21330713 problem in UTILITY/RUBY
April Chin <april.chin@oracle.com>
parents:
diff changeset
    28
 
eba741d252dc 21330713 problem in UTILITY/RUBY
April Chin <april.chin@oracle.com>
parents:
diff changeset
    29
   def test_api_endpoint
eba741d252dc 21330713 problem in UTILITY/RUBY
April Chin <april.chin@oracle.com>
parents:
diff changeset
    30
+    uri = URI.parse "http://example.com/foo"
eba741d252dc 21330713 problem in UTILITY/RUBY
April Chin <april.chin@oracle.com>
parents:
diff changeset
    31
+    target = MiniTest::Mock.new
eba741d252dc 21330713 problem in UTILITY/RUBY
April Chin <april.chin@oracle.com>
parents:
diff changeset
    32
+    target.expect :target, "gems.example.com"
eba741d252dc 21330713 problem in UTILITY/RUBY
April Chin <april.chin@oracle.com>
parents:
diff changeset
    33
+
eba741d252dc 21330713 problem in UTILITY/RUBY
April Chin <april.chin@oracle.com>
parents:
diff changeset
    34
+    dns = MiniTest::Mock.new
eba741d252dc 21330713 problem in UTILITY/RUBY
April Chin <april.chin@oracle.com>
parents:
diff changeset
    35
+    dns.expect :getresource, target, [String, Object]
eba741d252dc 21330713 problem in UTILITY/RUBY
April Chin <april.chin@oracle.com>
parents:
diff changeset
    36
+
eba741d252dc 21330713 problem in UTILITY/RUBY
April Chin <april.chin@oracle.com>
parents:
diff changeset
    37
+    fetch = Gem::RemoteFetcher.new nil, dns
eba741d252dc 21330713 problem in UTILITY/RUBY
April Chin <april.chin@oracle.com>
parents:
diff changeset
    38
+    assert_equal URI.parse("http://gems.example.com/foo"), fetch.api_endpoint(uri)
eba741d252dc 21330713 problem in UTILITY/RUBY
April Chin <april.chin@oracle.com>
parents:
diff changeset
    39
+
eba741d252dc 21330713 problem in UTILITY/RUBY
April Chin <april.chin@oracle.com>
parents:
diff changeset
    40
+    target.verify
eba741d252dc 21330713 problem in UTILITY/RUBY
April Chin <april.chin@oracle.com>
parents:
diff changeset
    41
+    dns.verify
eba741d252dc 21330713 problem in UTILITY/RUBY
April Chin <april.chin@oracle.com>
parents:
diff changeset
    42
+  end
eba741d252dc 21330713 problem in UTILITY/RUBY
April Chin <april.chin@oracle.com>
parents:
diff changeset
    43
+
eba741d252dc 21330713 problem in UTILITY/RUBY
April Chin <april.chin@oracle.com>
parents:
diff changeset
    44
+  def test_api_endpoint_ignores_trans_domain_values 
eba741d252dc 21330713 problem in UTILITY/RUBY
April Chin <april.chin@oracle.com>
parents:
diff changeset
    45
     uri = URI.parse "http://gems.example.com/foo"
eba741d252dc 21330713 problem in UTILITY/RUBY
April Chin <april.chin@oracle.com>
parents:
diff changeset
    46
     target = MiniTest::Mock.new
eba741d252dc 21330713 problem in UTILITY/RUBY
April Chin <april.chin@oracle.com>
parents:
diff changeset
    47
     target.expect :target, "blah.com"
eba741d252dc 21330713 problem in UTILITY/RUBY
April Chin <april.chin@oracle.com>
parents:
diff changeset
    48
@@ -171,7 +186,37 @@ gems:
eba741d252dc 21330713 problem in UTILITY/RUBY
April Chin <april.chin@oracle.com>
parents:
diff changeset
    49
     dns.expect :getresource, target, [String, Object]
eba741d252dc 21330713 problem in UTILITY/RUBY
April Chin <april.chin@oracle.com>
parents:
diff changeset
    50
 
eba741d252dc 21330713 problem in UTILITY/RUBY
April Chin <april.chin@oracle.com>
parents:
diff changeset
    51
     fetch = Gem::RemoteFetcher.new nil, dns
eba741d252dc 21330713 problem in UTILITY/RUBY
April Chin <april.chin@oracle.com>
parents:
diff changeset
    52
-    assert_equal URI.parse("http://blah.com/foo"), fetch.api_endpoint(uri)
eba741d252dc 21330713 problem in UTILITY/RUBY
April Chin <april.chin@oracle.com>
parents:
diff changeset
    53
+    assert_equal URI.parse("http://gems.example.com/foo"), fetch.api_endpoint(uri) 
eba741d252dc 21330713 problem in UTILITY/RUBY
April Chin <april.chin@oracle.com>
parents:
diff changeset
    54
+
eba741d252dc 21330713 problem in UTILITY/RUBY
April Chin <april.chin@oracle.com>
parents:
diff changeset
    55
+    target.verify
eba741d252dc 21330713 problem in UTILITY/RUBY
April Chin <april.chin@oracle.com>
parents:
diff changeset
    56
+    dns.verify
eba741d252dc 21330713 problem in UTILITY/RUBY
April Chin <april.chin@oracle.com>
parents:
diff changeset
    57
+  end
eba741d252dc 21330713 problem in UTILITY/RUBY
April Chin <april.chin@oracle.com>
parents:
diff changeset
    58
+
eba741d252dc 21330713 problem in UTILITY/RUBY
April Chin <april.chin@oracle.com>
parents:
diff changeset
    59
+  def test_api_endpoint_ignores_trans_domain_values_that_starts_with_original
eba741d252dc 21330713 problem in UTILITY/RUBY
April Chin <april.chin@oracle.com>
parents:
diff changeset
    60
+    uri = URI.parse "http://example.com/foo"
eba741d252dc 21330713 problem in UTILITY/RUBY
April Chin <april.chin@oracle.com>
parents:
diff changeset
    61
+    target = MiniTest::Mock.new
eba741d252dc 21330713 problem in UTILITY/RUBY
April Chin <april.chin@oracle.com>
parents:
diff changeset
    62
+    target.expect :target, "example.combadguy.com"
eba741d252dc 21330713 problem in UTILITY/RUBY
April Chin <april.chin@oracle.com>
parents:
diff changeset
    63
+
eba741d252dc 21330713 problem in UTILITY/RUBY
April Chin <april.chin@oracle.com>
parents:
diff changeset
    64
+    dns = MiniTest::Mock.new
eba741d252dc 21330713 problem in UTILITY/RUBY
April Chin <april.chin@oracle.com>
parents:
diff changeset
    65
+    dns.expect :getresource, target, [String, Object]
eba741d252dc 21330713 problem in UTILITY/RUBY
April Chin <april.chin@oracle.com>
parents:
diff changeset
    66
+
eba741d252dc 21330713 problem in UTILITY/RUBY
April Chin <april.chin@oracle.com>
parents:
diff changeset
    67
+    fetch = Gem::RemoteFetcher.new nil, dns
eba741d252dc 21330713 problem in UTILITY/RUBY
April Chin <april.chin@oracle.com>
parents:
diff changeset
    68
+    assert_equal URI.parse("http://example.com/foo"), fetch.api_endpoint(uri)
eba741d252dc 21330713 problem in UTILITY/RUBY
April Chin <april.chin@oracle.com>
parents:
diff changeset
    69
+
eba741d252dc 21330713 problem in UTILITY/RUBY
April Chin <april.chin@oracle.com>
parents:
diff changeset
    70
+    target.verify
eba741d252dc 21330713 problem in UTILITY/RUBY
April Chin <april.chin@oracle.com>
parents:
diff changeset
    71
+    dns.verify
eba741d252dc 21330713 problem in UTILITY/RUBY
April Chin <april.chin@oracle.com>
parents:
diff changeset
    72
+  end
eba741d252dc 21330713 problem in UTILITY/RUBY
April Chin <april.chin@oracle.com>
parents:
diff changeset
    73
+
eba741d252dc 21330713 problem in UTILITY/RUBY
April Chin <april.chin@oracle.com>
parents:
diff changeset
    74
+  def test_api_endpoint_ignores_trans_domain_values_that_end_with_original
eba741d252dc 21330713 problem in UTILITY/RUBY
April Chin <april.chin@oracle.com>
parents:
diff changeset
    75
+    uri = URI.parse "http://example.com/foo"
eba741d252dc 21330713 problem in UTILITY/RUBY
April Chin <april.chin@oracle.com>
parents:
diff changeset
    76
+    target = MiniTest::Mock.new
eba741d252dc 21330713 problem in UTILITY/RUBY
April Chin <april.chin@oracle.com>
parents:
diff changeset
    77
+    target.expect :target, "badexample.com"
eba741d252dc 21330713 problem in UTILITY/RUBY
April Chin <april.chin@oracle.com>
parents:
diff changeset
    78
+
eba741d252dc 21330713 problem in UTILITY/RUBY
April Chin <april.chin@oracle.com>
parents:
diff changeset
    79
+    dns = MiniTest::Mock.new
eba741d252dc 21330713 problem in UTILITY/RUBY
April Chin <april.chin@oracle.com>
parents:
diff changeset
    80
+    dns.expect :getresource, target, [String, Object]
eba741d252dc 21330713 problem in UTILITY/RUBY
April Chin <april.chin@oracle.com>
parents:
diff changeset
    81
+
eba741d252dc 21330713 problem in UTILITY/RUBY
April Chin <april.chin@oracle.com>
parents:
diff changeset
    82
+    fetch = Gem::RemoteFetcher.new nil, dns
eba741d252dc 21330713 problem in UTILITY/RUBY
April Chin <april.chin@oracle.com>
parents:
diff changeset
    83
+    assert_equal URI.parse("http://example.com/foo"), fetch.api_endpoint(uri)
eba741d252dc 21330713 problem in UTILITY/RUBY
April Chin <april.chin@oracle.com>
parents:
diff changeset
    84
 
eba741d252dc 21330713 problem in UTILITY/RUBY
April Chin <april.chin@oracle.com>
parents:
diff changeset
    85
     target.verify
eba741d252dc 21330713 problem in UTILITY/RUBY
April Chin <april.chin@oracle.com>
parents:
diff changeset
    86
     dns.verify