--- a/ChangeLog	Thu Oct 22 07:07:11 2009 +0000
+++ b/ChangeLog	Thu Oct 22 12:43:04 2009 +0000
@@ -1,3 +1,8 @@
+2009-10-22  Ghee Teo  <[email protected]>
+
+	Tidied up spec file based on comments from review.
+	* SUNWmm-common.spec:
+
 2009-10-22  Dave Lin <[email protected]>
 
         * base-specs/gnome-utils.spec: Bump to 2.28.1.

--- a/SUNWmm-common.spec	Thu Oct 22 07:07:11 2009 +0000
+++ b/SUNWmm-common.spec	Thu Oct 22 12:43:04 2009 +0000
@@ -22,6 +22,7 @@
 BuildRoot:           %{_tmppath}/%{name}-%{version}-build
 %include default-depend.inc
 Requires: SUNWbash
+Requires: SUNWperl584core
 
 %prep
 %setup -q -n mm-common-%{version}
@@ -42,8 +43,6 @@
 %install
 rm -rf $RPM_BUILD_ROOT
 make install DESTDIR=$RPM_BUILD_ROOT
-mkdir -p $RPM_BUILD_ROOT/usr/lib
-mv $RPM_BUILD_ROOT/usr/share/pkgconfig $RPM_BUILD_ROOT/usr/lib
 find $RPM_BUILD_ROOT -name '*.gitignore' -exec rm {} \;
 
 %clean
@@ -52,11 +51,11 @@
 %files
 %defattr (-, root, bin)
 %{_bindir}
-%dir %attr (0755, root, other) %{_libdir}/pkgconfig
-%dir %attr (0755, root, other) %{_libdir}/pkgconfig/*
 %dir %attr (0755, root, sys) %{_datadir}
 %dir %attr (0755, root, other) %{_datadir}/aclocal
 %dir %attr (0755, root, other) %{_datadir}/aclocal/*
+%dir %attr (0755, root, bin) %{_datadir}/pkgconfig
+%dir %attr (0755, root, bin) %{_datadir}/pkgconfig/*
 %{_mandir}
 %dir %attr (0755, root, other) %{_datadir}/mm-common
 %dir %attr (0755, root, other) %{_datadir}/mm-common/*
@@ -69,5 +68,7 @@
 %dir %attr (0755, root, other) %{_datadir}/doc/mm-common/skeletonmm/*/*/*
 
 %changelog
+* Thu Oct 21 2009 - [email protected]
+- Fixed some dependencies and also installation location.
 * Fri Oct 02 2009 - [email protected]
 - initial version